From: sashiko-bot@kernel.org
To: "Avi Weiss" <thnkslprpt@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf/core: Accumulate lost samples in inherited group reads
Date: Sun, 15 Nov 2026 15:22:55 +0000 [thread overview]
Message-ID: <sashiko-outbox-215620@kernel.org> (raw)
In-Reply-To: <20261115151458.258097-1-thnkslprpt@gmail.com>
> `__perf_read_group_add()` accumulates event counts from inherited
> child events, but overwrites the `PERF_FORMAT_LOST` fields. A
> child reporting no losses therefore hides nonzero parent losses
> while it is alive.
>
> Accumulate `lost_samples` for the group leader and siblings so
> group reads preserve losses across inherited events.
>
> Fixes: 119a784c8127 ("perf/core: Add a new read format to get a number of lost samples")
> Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115151458.258097-1-thnkslprpt@gmail.com?part=1
prev parent reply other threads:[~2026-11-15 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 15:14 [PATCH] perf/core: Accumulate lost samples in inherited group reads Avi Weiss
2026-11-15 15:22 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215620@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=thnkslprpt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox