Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 01/10] perf jevents: Store raw bytes in BigCString instead of C-escaped strings
Date: Mon, 16 Nov 2026 07:09:29 +0000	[thread overview]
Message-ID: <sashiko-outbox-216388@kernel.org> (raw)
In-Reply-To: <20261116070038.2968725-2-irogers@google.com>

> Previously BigCString stored C-escaped strings (with literal '\000',
> '\n', '\"', '\\') and estimated their compiled byte length via
> c_len(), which did not handle arbitrary escapes and caused both suffix
> folding and metricgroups sorting to compare '\000' ('\\' == 0x5c)
> rather than NUL (0x00). Notably, sorting metricgroup names with '\000'
> placed 'BadSpec\000' ('S' == 0x53) before 'Bad\000' ('\\' == 0x5c),
> breaking strcmp() binary search in describe_metricgroup("Bad").
> 
> Store raw NUL-delimited UTF-8 bytes directly in BigCString and
> _metricgroups, compute offsets from len(b) directly, remove c_len(), and
> escape bytes into C string literals only when emitting C source via
> bytes_to_c_literal().
> 
> Fixes: 66c6e0c10027 ("perf jevents: Add support for metricgroup descriptions")
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116070038.2968725-1-irogers@google.com?part=1


  reply	other threads:[~2026-11-16  7:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:00 [PATCH v2 00/10] perf jevents: Block-indexed string compression and default JEVENTS_ARCH=all Ian Rogers
2026-11-16  7:00 ` [PATCH v2 01/10] perf jevents: Store raw bytes in BigCString instead of C-escaped strings Ian Rogers
2026-11-16  7:09   ` sashiko-bot [this message]
2026-11-16  7:00 ` [PATCH v2 02/10] perf jevents: Sort BigCString entries alphabetically Ian Rogers
2026-11-16  7:05   ` sashiko-bot
2026-11-16  7:00 ` [PATCH v2 03/10] perf jevents: Store PMU names as string literals in struct pmu_table_entry Ian Rogers
2026-11-16  7:06   ` sashiko-bot
2026-11-16  7:00 ` [PATCH v2 04/10] perf jevents: Encapsulate big_c_string lookups behind pmu_events__get_string() Ian Rogers
2026-11-16  7:06   ` sashiko-bot
2026-11-16  7:00 ` [PATCH v2 05/10] perf jevents: Add block-indexed string packing and --compress=zlib Ian Rogers
2026-11-16  7:07   ` sashiko-bot
2026-11-16  7:00 ` [PATCH v2 06/10] perf jevents: Add --compress=lzma block compression backend Ian Rogers
2026-11-16  7:04   ` sashiko-bot
2026-11-16  7:00 ` [PATCH v2 07/10] perf jevents: Add --compress=zstd " Ian Rogers
2026-11-16  7:08   ` sashiko-bot
2026-11-16  7:00 ` [PATCH v2 08/10] perf build: Enable jevents string compression when available Ian Rogers
2026-11-16  7:10   ` sashiko-bot
2026-11-16  7:00 ` [PATCH v2 09/10] perf tests pmu-events: Test metricgroup descriptions and concurrent lookups Ian Rogers
2026-11-16  7:13   ` sashiko-bot
2026-11-16  7:00 ` [PATCH v2 10/10] perf build: Default JEVENTS_ARCH to all Ian Rogers
2026-11-16  7:16   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216388@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox