Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vasant Hegde" <vasant.hegde@amd.com>, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3] x86/events/amd/iommu: Use a per-IOMMU cpumask
Date: Mon, 16 Nov 2026 12:12:13 +0000	[thread overview]
Message-ID: <sashiko-outbox-216991@kernel.org> (raw)
In-Reply-To: <20261116115350.13740-1-vasant.hegde@amd.com>

> IOMMU performance counters are accessed via MMIO. The AMD IOMMU PMUs
> share one global cpumask, fixed to CPU0, so every IOMMU's events are
> read through the same CPU. That prevents collecting per-NUMA-node
> numbers (for example perf stat --per-socket). The mask is also never
> updated, so counting stops if that CPU goes offline.
> 
> Give each IOMMU PMU its own cpumask. The CPU is chosen from the online
> CPUs of the NUMA node of the IOMMU's PCI device, via
> amd_iommu_idx_to_dev(). If the node is unknown or has no online CPU,
> any online CPU is used. If no online CPU exists at all, that PMU is
> not registered.
> 
> A CPU hotplug callback moves the reader when that CPU goes offline,
> preferring another online CPU on the same node. If the reader had to
> leave the node, it moves back when a CPU on that node comes online.
> Events are pinned to the current reader so they share one context and
> migrate together.
> 
> Assisted-by: Cursor
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116115350.13740-1-vasant.hegde@amd.com?part=1


      reply	other threads:[~2026-11-16 12:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 11:53 [PATCH v3] x86/events/amd/iommu: Use a per-IOMMU cpumask Vasant Hegde
2026-11-16 12:12 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216991@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vasant.hegde@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox