Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Florian Fainelli" <f.fainelli@gmail.com>
Cc: "open list:PERFORMANCE EVENTS SUBSYSTEM"
	<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] MIPS: perf: Add SB1 and SB1A performance counter support
Date: Mon, 16 Nov 2026 17:55:28 +0000	[thread overview]
Message-ID: <sashiko-outbox-217459@kernel.org> (raw)
In-Reply-To: <20261116173843.911523-4-f.fainelli@gmail.com>

> Support the four CPU-local SB1 performance counters through the MIPS PMU
> driver. Use 64-bit CP0 accesses for the 40 count bits and overflow bit,
> validate the documented layout at initialization, and handle sampling on
> CPU-local IP7. Keep the interrupt masked while no events are scheduled and
> clear the unused Count/Compare source sharing IP7 before enabling it and
> in the handler. Reset counters through CPU hotplug callbacks.
> 
> Expose the historical OProfile event catalog through raw events and 48
> sysfs aliases, plus generic cycles, instructions, branches and branch
> misses. Preserve the catalog's duplicate encodings and disambiguate its
> duplicate names. Leave generic cache events unmapped where the historical
> descriptions do not establish a reliable mapping.
> 
> Add explicit physical counter selection and independent exclusions for
> EXL and ordinary kernel execution. These exclusions only remove modes
> already permitted by perf attributes. Enforce counter 0's cycles-only
> restriction and reject reserved configurations. Reassign flexible events
> when fixed-counter requests require it, preserving counts and sampling
> state, and support groups led by software events. Honor sampling throttling.
> 
> Document the ABI, hardware assumptions, usage and validation limits.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116173843.911523-1-f.fainelli@gmail.com?part=3


      reply	other threads:[~2026-11-16 17:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 17:38 [PATCH v3 0/3] MIPS: SiByte: Add HW PMU support Florian Fainelli
2026-11-16 17:38 ` [PATCH v3 1/3] MIPS: SiByte: Wire up the CPU interrupt controller Florian Fainelli
2026-11-16 17:50   ` sashiko-bot
2026-11-16 17:38 ` [PATCH v3 2/3] MIPS: perf: Add SB1 userspace callchain unwinding Florian Fainelli
2026-11-16 17:58   ` sashiko-bot
2026-11-16 17:38 ` [PATCH v3 3/3] MIPS: perf: Add SB1 and SB1A performance counter support Florian Fainelli
2026-11-16 17:55   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217459@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox