Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v4 03/12] perf annotate-data: Resolve DW_OP_addrx global variables
Date: Tue, 17 Nov 2026 00:03:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-217970@kernel.org> (raw)
In-Reply-To: <20261116234659.3950531-4-acme@kernel.org>

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> clang emits DW_AT_location with DW_OP_addrx for global variables in
> DWARF 5, gcc emits DW_OP_addr.  The address index was not resolved, so
> those variables were not found by address; the by-name fallback also
> missed the ones in .bss past the file backed end of the last segment.
> 
> Resolve the index with dwarf_getlocation_attr() + dwarf_formaddr() and
> use the resulting address in the by-address lookup and in the global
> variable cache.  The new global_data workload keeps a zero initialized
> struct in .bss and its test checks that the accesses are annotated: when
> perf is built with clang and DWARF 5 it goes through DW_OP_addrx, with
> gcc through DW_OP_addr.  The test skips on 32-bit PIE builds, which
> load globals through the GOT, something the resolver does not follow.
> 
> Fixes: d60469d7c0e5c4e8 ("perf dwarf-aux: Add die_find_variable_by_addr()")
> Fixes: d7b60803a790b716 ("perf dwarf-aux: Add die_collect_global_vars()")
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116234659.3950531-1-acme@kernel.org?part=3


  reply	other threads:[~2026-11-17  0:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 23:46 [PATCH v4 0/12] perf coverage: A harness for perf, and the fixes it found Arnaldo Carvalho de Melo
2026-11-16 23:46 ` [PATCH v4 01/12] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-16 23:55   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 02/12] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-17  0:03   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 03/12] perf annotate-data: Resolve DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-17  0:03   ` sashiko-bot [this message]
2026-11-17  0:10   ` Arnaldo Carvalho de Melo
2026-11-16 23:46 ` [PATCH v4 04/12] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-16 23:56   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 05/12] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-16 23:55   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 06/12] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-16 23:55   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 07/12] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-16 23:55   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 08/12] perf tests: Silence the libbfd probe in build-test Arnaldo Carvalho de Melo
2026-11-16 23:50   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 09/12] perf build: Record the display-only features in FEATURE-DUMP Arnaldo Carvalho de Melo
2026-11-17  0:00   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 10/12] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-17  0:06   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 11/12] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-16 23:56   ` sashiko-bot
2026-11-16 23:46 ` [PATCH v4 12/12] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo
2026-11-17  0:06   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217970@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=acme@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox