Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Gu Bin" <gubin@cmss.chinamobile.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf trace: free filter_pids entries in trace__exit()
Date: Tue, 17 Nov 2026 10:03:48 +0000	[thread overview]
Message-ID: <sashiko-outbox-218566@kernel.org> (raw)
In-Reply-To: <20261117095603.2397-1-gubin@cmss.chinamobile.com>

> trace__set_filter_pids_from_option() allocates trace->filter_pids.entries
> with calloc() when the --filter-pids option is parsed, but trace__exit()
> never frees it.  Free it there along with the other entries array of the
> trace struct, ev_qualifier_ids.
> 
> Fixes: f078c3852c73 ("perf trace: Introduce --filter-pids")
> Signed-off-by: Gu Bin <gubin@cmss.chinamobile.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117095603.2397-1-gubin@cmss.chinamobile.com?part=1


      parent reply	other threads:[~2026-11-17 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:56 [PATCH] perf trace: free filter_pids entries in trace__exit() Gu Bin
2026-11-17  9:56 ` [PATCH] perf parse-events: free partially copied terms if term cloning fails Gu Bin
2026-11-17 10:06   ` sashiko-bot
2026-11-17 10:03 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218566@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=gubin@cmss.chinamobile.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox