From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v7 10/13] perf build: Record the features checked outside FEATURE_TESTS
Date: Wed, 18 Nov 2026 22:04:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-222075@kernel.org> (raw)
In-Reply-To: <20261118215716.114868-11-acme@kernel.org>
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> llvm-perf and rust are in FEATURE_DISPLAY but not in FEATURE_TESTS, and
> jvmti and jvmti-cmlr are in neither list: they can't be part of the
> test-all fast path, which sets every FEATURE_TESTS entry to 1 when
> test-all.c builds. Since FEATURE-DUMP is written from FEATURE_TESTS
> only, a FEATURES_DUMP= build, as used by build-test, never sees them and
> silently builds without libLLVM, the rust workloads and the jvmti agent.
>
> Record the display features and the jvmti ones that aren't in
> FEATURE_TESTS in the dump after the regular feature checks have run.
>
> Fixes: 206dcfca1f5cfac3 ("perf build: Autodetect minimum required llvm-dev version")
> Fixes: 3f5dfa472ea6771c ("tools build: Fix rust feature detection")
> Cc: James Clark <james.clark@linaro.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118215716.114868-1-acme@kernel.org?part=10
next prev parent reply other threads:[~2026-11-18 22:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 21:57 [PATCH v7 0/13] perf coverage: A harness for perf, and the fixes it found Arnaldo Carvalho de Melo
2026-11-18 21:57 ` [PATCH v7 01/13] perf build: Link the jvmti agent and the GTK UI with EXTRA_CFLAGS Arnaldo Carvalho de Melo
2026-11-18 22:01 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 02/13] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-18 22:08 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 03/13] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-18 22:14 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 04/13] perf tests: Exercise DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-18 22:08 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 05/13] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-18 22:01 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 06/13] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-18 22:04 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 07/13] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-18 22:03 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 08/13] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-18 22:03 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 09/13] perf tests: Silence the libbfd probe in build-test Arnaldo Carvalho de Melo
2026-11-18 22:00 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 10/13] perf build: Record the features checked outside FEATURE_TESTS Arnaldo Carvalho de Melo
2026-11-18 22:04 ` sashiko-bot [this message]
2026-11-18 21:57 ` [PATCH v7 11/13] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-18 22:03 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 12/13] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-18 22:03 ` sashiko-bot
2026-11-18 21:57 ` [PATCH v7 13/13] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo
2026-11-18 22:04 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222075@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox