Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v8 03/13] perf annotate: Handle absolute addressing in data type profiling
Date: Wed, 18 Nov 2026 22:49:21 +0000	[thread overview]
Message-ID: <sashiko-outbox-222128@kernel.org> (raw)
In-Reply-To: <20261118223725.121500-4-acme@kernel.org>

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> 32-bit x86 accesses globals with absolute addresses, like
> "movl %eax,0x8c73448", but the operand parser only recognized the
> offset(reg) forms, so the operand had no memory reference and the
> resolver skipped it as not a memory access.
> 
> Parse a bare hex number as an absolute memory operand, including the
> negative disp32 the LLVM disassembler prints for values that do not fit
> an int, and use the address in the resolver; calls, whose operand is a
> branch target, are left out.  Let the instruction tracking record the
> type of an absolute global load in the destination register.  The
> displacement is sign extended for 64-bit objects, as the CPU does, and
> zero extended for 32-bit ones.  Values that do not fit the int offset,
> zero and the operands of relocatable objects, which are unrelocated
> addends, are skipped.
> 
> With bare numbers being memory operands, a frame base register of -1,
> "none", would also compare equal to the -1 "no register" of an absolute
> operand and take it for a stack access, so guard those comparisons.
> Operands left with no register, like a user space "%gs:imm", are no
> longer looked up as variables, which can change the data type stats of
> those samples.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118223725.121500-1-acme@kernel.org?part=3


  reply	other threads:[~2026-11-18 22:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 22:37 [PATCH v8 00/13] perf coverage: A harness for perf, and the fixes it found Arnaldo Carvalho de Melo
2026-11-18 22:37 ` [PATCH v8 01/13] perf build: Link the jvmti agent and the GTK UI with EXTRA_CFLAGS Arnaldo Carvalho de Melo
2026-11-18 22:42   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 02/13] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-18 22:48   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 03/13] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-18 22:49   ` sashiko-bot [this message]
2026-11-18 22:37 ` [PATCH v8 04/13] perf tests: Exercise DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-18 22:52   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 05/13] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-18 22:42   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 06/13] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-18 22:43   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 07/13] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-18 22:42   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 08/13] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-18 22:42   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 09/13] perf tests: Silence the libbfd probe in build-test Arnaldo Carvalho de Melo
2026-11-18 22:41   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 10/13] perf build: Record the features checked outside FEATURE_TESTS Arnaldo Carvalho de Melo
2026-11-18 22:44   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 11/13] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-18 22:43   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 12/13] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-18 22:43   ` sashiko-bot
2026-11-18 22:37 ` [PATCH v8 13/13] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo
2026-11-18 22:44   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222128@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=acme@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox