From: sashiko-bot@kernel.org
To: "Andrii Nakryiko" <andrii@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 3/3] selftests/bpf: Run stacktrace_ips raw_tp, tp and fentry tests on arm64
Date: Thu, 19 Nov 2026 00:05:26 +0000 [thread overview]
Message-ID: <sashiko-outbox-222227@kernel.org> (raw)
In-Reply-To: <20261119000112.2377949-4-andrii@kernel.org>
> The raw_tp, tp and fentry subtests check stacks unwound from
> perf_fetch_caller_regs() regs. Now that arm64 perf_callchain_kernel()
> skips regs->pc of such regs and no longer reports the caller twice,
> run these subtests on arm64 as well, where kernel stacks are always
> unwound through frame records.
>
> Leave the kprobe, kretprobe, kprobe_multi, kretprobe_multi and fexit
> subtests x86-only: on arm64, kprobes at function entry miss the probed
> function's caller, and fexit stacks have an extra entry for the traced
> function. The kretprobe subtests pass on arm64, but don't use
> perf_fetch_caller_regs() regs.
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119000112.2377949-1-andrii@kernel.org?part=3
prev parent reply other threads:[~2026-11-19 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 0:01 [PATCH bpf-next v2 0/3] Fix duplicate caller frame in arm64 stack traces Andrii Nakryiko
2026-11-19 0:01 ` [PATCH bpf-next v2 1/3] arm64: perf: Don't report the caller twice in caller-regs callchains Andrii Nakryiko
2026-11-19 0:22 ` sashiko-bot
2026-11-19 0:01 ` [PATCH bpf-next v2 2/3] selftests/bpf: Add stacktrace_ips test for tracepoint Andrii Nakryiko
2026-11-19 0:07 ` sashiko-bot
2026-11-19 0:01 ` [PATCH bpf-next v2 3/3] selftests/bpf: Run stacktrace_ips raw_tp, tp and fentry tests on arm64 Andrii Nakryiko
2026-11-19 0:05 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222227@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=andrii@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox