Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Colton Lewis" <coltonlewis@google.com>
Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	"Oliver Upton" <oupton@kernel.org>,
	"Marc Zyngier" <maz@kernel.org>
Subject: Re: [PATCH v10 14/33] KVM: arm64: Add Partitioned PMU register trap handlers
Date: Thu, 19 Nov 2026 19:21:52 +0000	[thread overview]
Message-ID: <sashiko-outbox-223868@kernel.org> (raw)
In-Reply-To: <20261119185215.632334-15-coltonlewis@google.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] KVM: arm64: missing 32-bit counter mask in
  kvm_pmu_direct_cntr_read()
--

commit a61557b3819ee55851d36163d0d9444fd60c695d
Author: Colton Lewis <coltonlewis@google.com>

KVM: arm64: Add Partitioned PMU register trap handlers

This commit adds direct PMU register read and write handlers for VMs using
a Partitioned PMU and dispatches trapped PMU accesses to them.

> diff --git a/arch/arm64/kvm/pmu-direct.c b/arch/arm64/kvm/pmu-direct.c
> index b1c180ae79d9d..13f5bcc2a9084 100644
> --- a/arch/arm64/kvm/pmu-direct.c
> +++ b/arch/arm64/kvm/pmu-direct.c

[ ... ]

> @@ -79,6 +92,245 @@ static u64 kvm_vcpu_pmu_guest_counter_mask(struct kvm_vcpu *vcpu)
>  	return 0;
>  }

[ ... ]

> +static u64 kvm_pmu_direct_cntr_read(struct kvm_vcpu *vcpu, u8 idx)
> +{
> +	lockdep_assert_preemption_disabled();
> +
> +	if (!kvm_pmu_part_on_cpu(vcpu))
> +		return __vcpu_sys_reg(vcpu, PMEVCNTR0_EL0 + idx);
> +
> +	if (idx == ARMV8_PMU_CYCLE_IDX)
> +		return read_pmccntr();
> +
> +	return read_pmevcntrn(idx);
> +}
> +
> +static void kvm_pmu_direct_cntr_write(struct kvm_vcpu *vcpu, u8 idx, u64 val)
> +{
> +	lockdep_assert_preemption_disabled();
> +
> +	__vcpu_assign_sys_reg(vcpu, PMEVCNTR0_EL0 + idx, val);
> +	if (!kvm_pmu_part_on_cpu(vcpu))
> +		return;
> +
> +	if (idx == ARMV8_PMU_CYCLE_IDX)
> +		write_pmccntr(val);
> +	else
> +		write_pmevcntrn(idx, val);
> +}

[ ... ]

> +void kvm_pmu_direct_reg_write(struct kvm_vcpu *vcpu, unsigned int reg,
> +			      u64 val, bool set)
> +{
> +	unsigned long flags;
> +	u64 mask;
> +	int idx;
> +
> +	guard(preempt)();
> +
> +	switch (reg) {
> +	case PMCR_EL0:
> +		kvm_pmu_direct_pmcr_write(vcpu, val);
> +		break;
> +	case PMSELR_EL0:
> +		if (kvm_pmu_part_on_cpu(vcpu) &&
> +		    !(vcpu->arch.mdcr_el2 & MDCR_EL2_TPM))
> +			write_sysreg(val, pmselr_el0);
> +		__vcpu_assign_sys_reg(vcpu, reg, val);
> +		break;
> +	case PMEVCNTR0_EL0 ... PMCCNTR_EL0:
> +		idx = reg - PMEVCNTR0_EL0;
> +		if (vcpu_mode_is_32bit(vcpu) && idx != ARMV8_PMU_CYCLE_IDX)
> +			val = (kvm_pmu_direct_cntr_read(vcpu, idx) &
> +			       GENMASK_ULL(63, 32)) |
> +			      lower_32_bits(val);
> +		kvm_pmu_direct_cntr_write(vcpu, idx, val);
> +		break;

[Severity: Low]
Should kvm_pmu_direct_cntr_read() and kvm_pmu_direct_reg_write() mask
general-purpose event counters to 32 bits when the VM does not have
FEAT_PMUv3p5?

kvm_pmu_direct_pmcr_read() and kvm_pmu_direct_pmcr_write() clear
ARMV8_PMU_PMCR_LP when !kvm_has_feat(vcpu->kvm, ID_AA64DFR0_EL1, PMUVer,
V3P5), and the emulated path in kvm_pmu_get_pmc_value() truncates
general-purpose counters via lower_32_bits() when FEAT_PMUv3p5 is absent.
Here, trapped 64-bit guest accesses to PMEVCNTR<n>_EL0 or PMXEVCNTR_EL0
store and return the full 64-bit value, exposing bits [63:32] to a guest
configured without FEAT_PMUv3p5.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119185215.632334-1-coltonlewis@google.com?part=14

  reply	other threads:[~2026-11-19 19:21 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 18:51 [PATCH v10 00/33] ARM64 PMU Partitioning Colton Lewis
2026-11-19 18:51 ` [PATCH v10 01/33] arm64: cpufeature: Add cpucap for HPMN0 Colton Lewis
2026-11-19 19:08   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 02/33] KVM: arm64: Reorganize PMU includes Colton Lewis
2026-11-19 19:00   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 03/33] KVM: arm64: Reorganize PMU functions Colton Lewis
2026-11-19 18:57   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 04/33] KVM: arm64: Use nr_pmu_counters in kvm_pmu_implemented_counter_mask() Colton Lewis
2026-11-19 19:08   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 05/33] KVM: arm64: Ignore HPMN for userspace PMU register access Colton Lewis
2026-11-19 18:58   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 06/33] perf: arm_pmuv3: Generalize counter bitmasks Colton Lewis
2026-11-19 18:56   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 07/33] perf: arm_pmuv3: Move counter allocation mask to per-CPU struct pmu_hw_events Colton Lewis
2026-11-19 19:04   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 08/33] perf: arm_pmuv3: Check cntr_mask before using pmccntr Colton Lewis
2026-11-19 19:01   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 09/33] perf: arm_pmuv3: Allocate counter indices from high to low Colton Lewis
2026-11-19 18:57   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 10/33] perf: arm_pmuv3: Expose number of general-purpose counters in sysfs Colton Lewis
2026-11-19 18:57   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 11/33] KVM: arm64: Add initial scaffolding for Partitioned PMU Colton Lewis
2026-11-19 18:58   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 12/33] KVM: arm64: Set up FGT " Colton Lewis
2026-11-19 19:13   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 13/33] KVM: arm64: Make __vcpu_rmw_sys_reg() atomic Colton Lewis
2026-11-19 18:58   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 14/33] KVM: arm64: Add Partitioned PMU register trap handlers Colton Lewis
2026-11-19 19:21   ` sashiko-bot [this message]
2026-11-19 18:51 ` [PATCH v10 15/33] KVM: arm64: Construct mdcr_el2 in a local variable in kvm_arm_setup_mdcr_el2() Colton Lewis
2026-11-19 18:56   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 16/33] KVM: arm64: Set up MDCR_EL2 to handle a Partitioned PMU Colton Lewis
2026-11-19 19:21   ` sashiko-bot
2026-11-19 18:51 ` [PATCH v10 17/33] KVM: arm64: Context swap Partitioned PMU guest registers Colton Lewis
2026-11-19 19:17   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 18/33] KVM: arm64: Enforce PMU event filter at vcpu_load() Colton Lewis
2026-11-19 19:14   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 19/33] perf: Add perf_pmu_resched_update() Colton Lewis
2026-11-19 19:02   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 20/33] perf/core: Prioritize kernel-owned pinned events when scheduling groups Colton Lewis
2026-11-19 19:01   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 21/33] KVM: arm64: Allow kvm_vcpu_pmu_resync_el0() to resync filters in process context Colton Lewis
2026-11-19 19:07   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 22/33] KVM: arm64: Apply dynamic guest counter reservations Colton Lewis
2026-11-19 19:21   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 23/33] KVM: arm64: Implement lazy PMU context swaps Colton Lewis
2026-11-19 19:24   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 24/33] perf: arm_pmuv3: Handle IRQs for Partitioned PMU guest counters Colton Lewis
2026-11-19 19:22   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 25/33] KVM: arm64: Detect overflows for the Partitioned PMU Colton Lewis
2026-11-19 19:15   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 26/33] KVM: arm64: Multiplex PMCR_EL0.E and MDCR_EL2.HPME for sub-partitioned L1 Colton Lewis
2026-11-19 19:16   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 27/33] KVM: arm64: Emulate mismatched LP and HLP overflow widths " Colton Lewis
2026-11-19 19:26   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 28/33] KVM: arm64: Emulate trapped PMSWINC_EL0 writes for Partitioned PMU Colton Lewis
2026-11-19 19:13   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 29/33] KVM: arm64: Forward FGT traps for PMXEVTYPER_EL0 and PMXEVCNTR_EL0 Colton Lewis
2026-11-19 19:15   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 30/33] KVM: arm64: Support zero event counters on Partitioned PMU without HPMN0 Colton Lewis
2026-11-19 19:20   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 31/33] KVM: arm64: Add vCPU device attr to partition the PMU Colton Lewis
2026-11-19 19:14   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 32/33] KVM: selftests: Add find_bit to KVM library Colton Lewis
2026-11-19 19:07   ` sashiko-bot
2026-11-19 18:52 ` [PATCH v10 33/33] KVM: arm64: selftests: Add test case for Partitioned PMU Colton Lewis
2026-11-19 19:14   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223868@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=coltonlewis@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox