From: sashiko-bot@kernel.org
To: "Amir Ayupov" <aaupov@fb.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v6 2/4] coresight: etm4x: Skip features requiring unavailable events
Date: Fri, 20 Nov 2026 19:16:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-225899@kernel.org> (raw)
In-Reply-To: <af7838ccf521e6317dbc3ef706dd4b8c979740fa.1795196854.git.aaupov@fb.com>
> Feature register mappings accept TRCEVENTCTL0R without checking which
> event fields the trace unit implements. A feature that drives EVENT1 can
> therefore load on a trace unit with only EVENT0 and silently produce no
> pulses.
>
> Validate the descriptors before checking their requested EVENT fields
> against the decoded event count. Parameterized writes are checked against
> every writable field because parameter values may change after loading.
> Let the configuration manager treat -EOPNOTSUPP as a per-device skip and
> release the unlinked feature instance, while malformed descriptions and
> other errors still abort loading.
>
> Suggested-by: Mike Leach <mike.leach@arm.com>
> Assisted-by: Devmate:GPT-6.1-Sol
> Signed-off-by: Amir Ayupov <aaupov@fb.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795196854.git.aaupov@fb.com?part=2
next prev parent reply other threads:[~2026-11-20 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 18:54 [PATCH v6 0/4] coresight: Pulse an ETM external output for a PMU event Amir Ayupov
2026-11-20 18:54 ` [PATCH v6 1/4] coresight: etm4x: Fix event count decoding Amir Ayupov
2026-11-20 19:03 ` sashiko-bot
2026-11-20 18:54 ` [PATCH v6 2/4] coresight: etm4x: Skip features requiring unavailable events Amir Ayupov
2026-11-20 19:16 ` sashiko-bot [this message]
2026-11-20 18:54 ` [PATCH v6 3/4] coresight: perf: Filter sources lacking the selected configuration Amir Ayupov
2026-11-20 19:05 ` sashiko-bot
2026-11-20 18:54 ` [PATCH v6 4/4] coresight: Add pmu_pulse/extout_pulse Amir Ayupov
2026-11-20 19:02 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225899@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=aaupov@fb.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox