From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v10 16/16] perf scripts: Add a coverage table
Date: Sat, 21 Nov 2026 03:34:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-226587@kernel.org> (raw)
In-Reply-To: <20261121032052.1392234-17-acme@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] perf scripts: unbounded prefix stripping in under_build()
drops source files
--
commit 4ac2ff16920b880b37f2d7980a454661167aa1a9
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
perf scripts: Add a coverage table
This commit adds tools/perf/scripts/coverage-table.sh and a coverage-table
make target to render the last coverage run's report.txt as a text table.
> diff --git a/tools/perf/scripts/coverage-table.sh b/tools/perf/scripts/coverage-table.sh
> new file mode 100755
> index 0000000000000..8aa538255e9be
> --- /dev/null
> +++ b/tools/perf/scripts/coverage-table.sh
> @@ -0,0 +1,310 @@
[ ... ]
> +# An in-tree build has the sources below BUILD_DIR, so only a separate
> +# build directory can tell generated files apart from the tree's sources.
> +BUILD_AWK_DIR=$BUILD_DIR
> +[ "$BUILD_DIR" = "$PERF_DIR" ] && BUILD_AWK_DIR=
> +
> +# llvm-cov strips the prefix every reported file has in common, so a
> +# tools/perf source can read as perf/util/evsel.c.
> +AWK_PERF='
> +function perf_relpath(p) {
> + sub(/^.*tools\/perf\//, "", p)
> + sub(/^perf\//, "", p)
> + return p
> +}
> +function under_build(p, b, n) {
> + if (build == "")
> + return 0
> + b = build
> + while (1) {
> + n = length(b)
> + if (substr(p, 1, n + 1) == b "/")
> + return 1
> + if (index(b, "/") == 0)
> + return 0
> + sub(/^[^\/]*\//, "", b)
> + if (b == "")
> + return 0
> + }
> +}
[Severity: Medium]
Can under_build() match every tools/perf source file in report.txt when
BUILD_DIR shares a parent directory with PERF_DIR and ends with a path
component like perf or tools/perf?
under_build() strips leading path components from build all the way down
to its basename instead of stopping where BUILD_DIR diverges from
PERF_DIR. For an out-of-tree build such as O=/path/to/linux/tools/build/perf
(or O=/home/user/build/perf for a tree at /home/user/perf), llvm-cov
strips the common prefix so source paths in report.txt begin with perf/,
and b shrinks to perf. generated() then returns 1 for every source file,
leaving table_rows() empty and causing print_table() to exit with an
error.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121032052.1392234-1-acme@kernel.org?part=16
next prev parent reply other threads:[~2026-11-21 3:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 3:20 [PATCH v10 00/16] perf coverage: A harness for perf, and the fixes it found Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 01/16] perf build: Link the GTK UI with EXTRA_CFLAGS Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 02/16] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 03/16] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 04/16] perf build: Record the features checked outside FEATURE_TESTS Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 05/16] perf annotate-x86: Parse movabs like a mov Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 06/16] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 07/16] perf tests: Exercise the x86 operand parser Arnaldo Carvalho de Melo
2026-11-21 3:29 ` sashiko-bot
2026-11-21 3:20 ` [PATCH v10 08/16] perf tests: Exercise DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 09/16] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 10/16] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 11/16] perf tests: Exercise the annotate stats output Arnaldo Carvalho de Melo
2026-11-21 3:30 ` sashiko-bot
2026-11-21 3:20 ` [PATCH v10 12/16] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 13/16] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 14/16] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo
2026-11-21 3:20 ` [PATCH v10 15/16] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-21 3:36 ` sashiko-bot
2026-11-21 3:20 ` [PATCH v10 16/16] perf scripts: Add a coverage table Arnaldo Carvalho de Melo
2026-11-21 3:34 ` sashiko-bot [this message]
2026-11-21 3:36 ` [PATCH v10 00/16] perf coverage: A harness for perf, and the fixes it found sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-226587@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox