Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alireza Haghdoost" <haghdoost@uber.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf dso: Stay in perf's mount namespace for cached debuginfo
Date: Sat, 21 Nov 2026 22:32:48 +0000	[thread overview]
Message-ID: <sashiko-outbox-227446@kernel.org> (raw)
In-Reply-To: <20261121-perf-dso-ns-fix-v1-1-897322ddadf8@uber.com>

> From: Alireza Haghdoost <haghdoost@uber.com>
> 
> When perf reads the data of a DSO that belongs to a process in another
> mount namespace, open_dso() enters that namespace to open the file. It
> does not do this for files in perf's own build-id cache, but it only
> checks for DSO_BINARY_TYPE__BUILD_ID_CACHE.
> 
> Cached debuginfo files (DSO_BINARY_TYPE__BUILD_ID_CACHE_DEBUGINFO) are
> in the same build-id cache, yet open_dso() looks for them in the
> target's namespace. The file is usually not there, so for example
> perf script -F +insn prints no instruction bytes. If a file with the
> same path does exist there, perf reads the wrong file.
> 
> This patch skips the namespace switch for both build-id cache types, as
> dso__load() already does.
> 
> Fixes: 5363c306787c ("perf symbol: Set binary_type of dso when loading")
> Signed-off-by: Alireza Haghdoost <haghdoost@uber.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121-perf-dso-ns-fix-v1-1-897322ddadf8@uber.com?part=1

      reply	other threads:[~2026-11-21 22:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 22:25 [PATCH] perf dso: Stay in perf's mount namespace for cached debuginfo Alireza Haghdoost via B4 Relay
2026-11-21 22:32 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227446@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=haghdoost@uber.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox