From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 807BACA0FF0 for ; Fri, 29 Aug 2025 13:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fTUBAzRgeNOjcRWFMcZxnXsPWtoXZEkOnvV5aSFikyw=; b=uVX9vfmY3Xt4ek ZXLYI+Xxa8FTqbC/G0cs6PrTEat/x7Qi5ije0cAJpgMvR0YZPIRxXiWCpNWoMF9ixz5teHYg7GSGG v0JJuItixH8lCqfzS9th7YvHDcMJwXaw7cpp+AHdnIhO0n3LDSt4nSoyjbSFiLWCd5DFaOA00QMb9 rhcSwDvVvJBxmEpybYHB1F4znIg8qAKHVwzHGaG4JIHCW7wiAJdZ6tOF+fFTLvsdjuy/1kPO2btFH G39i8L0Gd5pXVdsnNmWEnw7iX1nv06kYw7mqPdWM+dzshgC3OVgvL5YXFqqvsRPbK5AS3/+gLUPhH wE3VGpaW07AeRMCWcKIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uryiV-00000005jgc-1FVw; Fri, 29 Aug 2025 13:00:31 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1urw9S-00000005Hsf-3K2X for linux-phy@lists.infradead.org; Fri, 29 Aug 2025 10:16:14 +0000 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20250829101605epoutp027816ab8f5f78f3fdc97ce178bd76919e~gNWWV2JxN0474904749epoutp02b for ; Fri, 29 Aug 2025 10:16:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20250829101605epoutp027816ab8f5f78f3fdc97ce178bd76919e~gNWWV2JxN0474904749epoutp02b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1756462565; bh=Lv9U/ELR3k6SWjrkU4O+mI6LWfxEz2ED3Y1tR6NHKF8=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=K8zlWAwjIwtvi/+yHoiwMgdpm6OZCS3twkn64fcDL3ezfmTHEGta4XlPTeny5KUiu uTAoZ2f2HNbimqYOFs1Ge0tjppgXxdpXcWCZ7RVejc683tYCzk7x8kQxF8CURmJNlo dSZTFDsjn5W0gLP6v8YJGvlFM0iUo84xXJx3Ow3U= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPS id 20250829101604epcas5p152dde9d0bc1d2d685fecec6f444a072f~gNWVbT5zR1738917389epcas5p1J; Fri, 29 Aug 2025 10:16:04 +0000 (GMT) Received: from epcas5p3.samsung.com (unknown [182.195.38.95]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4cCvLC1BF6z6B9mB; Fri, 29 Aug 2025 10:16:03 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20250829101602epcas5p357dad3ca9854d8150d975508acd57baf~gNWT11fFd0379903799epcas5p3K; Fri, 29 Aug 2025 10:16:02 +0000 (GMT) Received: from INBRO001840 (unknown [107.122.3.105]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250829101559epsmtip1de730ab72a1d43c000095ca871496224~gNWQtljFh1842718427epsmtip17; Fri, 29 Aug 2025 10:15:58 +0000 (GMT) From: "Pritam Manohar Sutar" To: "'Krzysztof Kozlowski'" Cc: , , , , , , , , , , , , , , , , , , , , , , , In-Reply-To: <83dc9435-5850-425d-b345-52e84ef9262c@kernel.org> Subject: RE: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy Date: Fri, 29 Aug 2025 15:45:37 +0530 Message-ID: <000401dc18cd$ec02a1b0$c407e510$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGSd8blfqR9gZc/NH28iGAFaSn12QHbdVSHAGa/K48CXY/t+wLwFCB2ArX7ZGy0uja2wA== Content-Language: en-in X-CMS-MailID: 20250829101602epcas5p357dad3ca9854d8150d975508acd57baf X-Msg-Generator: CA CMS-TYPE: 105P cpgsPolicy: CPGSC10-542,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250822093022epcas5p42d8c16c851769dab0e1da9d45743ab1f References: <20250822093845.1179395-1-pritam.sutar@samsung.com> <20250822093845.1179395-6-pritam.sutar@samsung.com> <20250824-rough-fresh-orangutan-eecb2f@kuoka> <007501dc1653$e36c3b50$aa44b1f0$@samsung.com> <83dc9435-5850-425d-b345-52e84ef9262c@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250829_031611_572047_A120D47F X-CRM114-Status: GOOD ( 31.26 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski > Sent: 26 August 2025 02:05 PM > To: Pritam Manohar Sutar > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; . . [snip] . . > >> Subject: Re: [PATCH v7 5/6] dt-bindings: phy: samsung,usb3-drd-phy: > >> add > >> ExynosAutov920 combo ssphy > >> > >> On Fri, Aug 22, 2025 at 03:08:44PM +0530, Pritam Manohar Sutar wrote: > >>> This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > >>> compatible to the USB3.0 SS(5Gbps). It requires two clocks, named > >>> "phy" and "ref". The required supplies for USB3.1 are named as > >>> vdd075_usb30(0.75v), vdd18_usb30(1.8v). > >> > >> Please do not describe the schema, but hardware. This sentence does > >> not help me in my question further. > > > > This is a combo phy having Synopsys usb20 and usb30 phys (these 2 phys are > totally different). > > One PHY only supports usb2.0 and data rates whereas another one does > > usb3.1 ssp+ and usb3.1 ssp > > > > This patch only explains about usb30 (since these are two different phys) phy > and omitted inclusion of usb20 reference (added separate patch for this patch > no 3). > > > > Hope this is clear. > > No. That sentence still explains what schema is doing. > Ok, let me simplify the commit message further something like below. Anyways, the coverletter contains more details about it. "dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy Add schema for combo ssphy found on this SoC. " Please confirm if this looks fine? If so, will reflect the similar commit messages in patch 1 and 3. > BTW, wrap your email correctly. > Sure, thanks for your input. > > > >> > >>> > >>> Add schemas for combo ssphy found on this SoC. > >>> > >>> Signed-off-by: Pritam Manohar Sutar > >>> --- > >>> .../bindings/phy/samsung,usb3-drd-phy.yaml | 23 +++++++++++++++++++ > >>> 1 file changed, 23 insertions(+) > >>> > >>> diff --git > >>> a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > >>> b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > >>> index f0cfca5736b8..96e5bbb2e42c 100644 > >>> --- > >>> a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > >>> +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yam > >>> +++ l > >>> @@ -34,6 +34,7 @@ properties: > >>> - samsung,exynos7870-usbdrd-phy > >>> - samsung,exynos850-usbdrd-phy > >>> - samsung,exynos990-usbdrd-phy > >>> + - samsung,exynosautov920-usb31drd-combo-ssphy > >>> - samsung,exynosautov920-usbdrd-combo-hsphy > >>> - samsung,exynosautov920-usbdrd-phy > >>> > >>> @@ -118,6 +119,12 @@ properties: > >>> vdd18-usb20-supply: > >>> description: 1.8V power supply for the USB 2.0 phy. > >>> > >>> + dvdd075-usb30-supply: > >>> + description: 0.75V power supply for the USB 3.0 phy. > >>> + > >>> + vdd18-usb30-supply: > >>> + description: 1.8V power supply for the USB 3.0 phy. > >>> + > >>> required: > >>> - compatible > >>> - clocks > >>> @@ -227,6 +234,7 @@ allOf: > >>> - samsung,exynos7870-usbdrd-phy > >>> - samsung,exynos850-usbdrd-phy > >>> - samsung,exynos990-usbdrd-phy > >>> + - samsung,exynosautov920-usb31drd-combo-ssphy > >>> - samsung,exynosautov920-usbdrd-combo-hsphy > >>> - samsung,exynosautov920-usbdrd-phy > >>> then: > >>> @@ -262,6 +270,21 @@ allOf: > >>> properties: > >>> dvdd075-usb20-supply: false > >>> vdd18-usb20-supply: false > >>> + - if: > >>> + properties: > >>> + compatible: > >>> + contains: > >>> + enum: > >>> + - samsung,exynosautov920-usb31drd-combo-ssphy > >>> + then: > >>> + required: > >>> + - dvdd075-usb30-supply > >>> + - vdd18-usb30-supply > >> > >> Why are you adding usb20 and usb30 suffixes to the supplies? These > >> are separate devices, so they do not have both variants at the same time. > > > > This is a combo phy consisting of usb2 and usb3 phys combined. > > To drive these separate phys, added suffixes for these supplies respectively. > > But they are separate. > > > > > Moreover, gs101 is also using similar convention for its usb20 and dp supplies. > > Added suffix for usb2 and usb3 as per our last communication > > https://lore.kernel.org/linux-phy/6e1c67d2-9bfa-442a-9d53-8c5970a2a9ef > > @kernel.org/ > > Then please review patches on the list and help to improve them BEFORE they > got merged. > > I questioned the suffix there, so I really do not understand why did you added it. > > > > >> > >> From this device point of view, the supply is called dvdd075 or vdd18. > >> If you open device datasheet (not SoC datasheet), that's how it will > >> be called, most likely. > > > > Yes, Agree. In device datasheet, suffixes are not mentioned, but in our board > schematic it is mentioned. > > Let me know your suggestion about adding suffixes? > > I already said, multiple times on various discussions. You name these based on > how the inputs are called in this device. Ok, will remove suffixes from supplies. And will add following supplies dvdd, vdd33 and vdd18. Let me know, because of above changes, should be removing your 'reviewed-by' tag from patch 1 and 3. > > Best regards, > Krzysztof Thank you. Regards, Pritam -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy