From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D5D3CA0EF5 for ; Tue, 19 Aug 2025 08:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pl3CCB676y7jtUMPuxgysLZHpJd+RkL8hevJRsi20Zw=; b=AfWd5sndzatjq6 WB+LNOTA5gXZ6g8aOurJQBox3M39uSaEm5ei63Z0NaNnZOWimvFW1SOobbb6X+bZ4zkztpnHTwniU AoLJNBKWx9Y8TpQ6TIroPxsVzvtbEZ0QfDf3QmUvA98jrCwZ78spObfbwKf9QPViISCG//hXTbdzl T2X9/jhQgmwSRT3q09jeN0XNODN1OJFJYEHQ+yhmoCT1Tn7XB87vqQc9Vcf9ErZk6+UCf9vkji+es yrEjwRwREzzu4VJBfG5IenvsYOOeTAh6aGp3EZQwfOXSa3CT4n/WVwR0sApCP5xUyF2/Vli04sTYc D28xtwRCfpJxtjMBvULg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uoI1j-00000009qoL-1EYE; Tue, 19 Aug 2025 08:49:07 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uoHTC-00000009lxt-0s5H for linux-phy@lists.infradead.org; Tue, 19 Aug 2025 08:13:28 +0000 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20250819081319epoutp0468f192fb10535ff6a612b6e38b5afe85~dHOUKYzMb1779217792epoutp04J for ; Tue, 19 Aug 2025 08:13:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20250819081319epoutp0468f192fb10535ff6a612b6e38b5afe85~dHOUKYzMb1779217792epoutp04J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1755591199; bh=UxiKAyBziT9e+nTMG+2xkk2xG/b2nNG83CX/r2e5bz4=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=J9sgQ4/PiSeAhGcrXAvZsGIjGReblZLfUSDGsK1e6qMBwvd2scEn0tQZJvrcqR4Pc gzyGg8xtJ4+8UI+QbYoEDNGlKkHxYUeNO4920fxFDZltSMKXWGS2kYlP3fC4/Jd/7/ pG+r/qPZLOy3wprc9/ydkrxShIImsWLcwOdC3Qrk= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPS id 20250819081318epcas5p3324c7219edd64e8c1fc1e87d1abc60a7~dHOS4TnRk1172211722epcas5p30; Tue, 19 Aug 2025 08:13:18 +0000 (GMT) Received: from epcas5p3.samsung.com (unknown [182.195.38.88]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4c5j594yK1z3hhT8; Tue, 19 Aug 2025 08:13:17 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20250819074434epcas5p3aba12adc12ef9a64dceff0ba5ec62e4d~dG1Ng9NQA3036730367epcas5p3E; Tue, 19 Aug 2025 07:44:34 +0000 (GMT) Received: from INBRO001840 (unknown [107.122.3.105]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250819074431epsmtip15ad820317f1a1565de1ff3da8c977d8a~dG1KpWY5o2126621266epsmtip1k; Tue, 19 Aug 2025 07:44:31 +0000 (GMT) From: "Pritam Manohar Sutar" To: "'Vinod Koul'" Cc: , , , , , , , , , , , , , , , , , , , , , In-Reply-To: Subject: RE: [PATCH v5 6/6] phy: exynos5-usbdrd: support SS combo phy for ExynosAutov920 Date: Tue, 19 Aug 2025 13:14:30 +0530 Message-ID: <003401dc10dd$1b39c560$51ad5020$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJ+ZgWj3OwstM5ZbwFL0KmcSzrOlQGuc5yxAsdJ9S8B+nVVqAJlMeHKAknGxWeyy/PDQA== Content-Language: en-in X-CMS-MailID: 20250819074434epcas5p3aba12adc12ef9a64dceff0ba5ec62e4d X-Msg-Generator: CA X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P cpgsPolicy: CPGSC10-542,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250805114323epcas5p39bf73c5e0a9382ff54b1832724804cc9 References: <20250805115216.3798121-1-pritam.sutar@samsung.com> <20250805115216.3798121-7-pritam.sutar@samsung.com> <038a01dc1013$900a2800$b01e7800$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250819_011326_955919_6983C0E7 X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Vinod, > -----Original Message----- > From: Vinod Koul > Sent: 19 August 2025 12:25 PM > To: Pritam Manohar Sutar > Cc: kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org; > peter.griffin@linaro.org; kauschluss@disroot.org; > ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org; > m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v5 6/6] phy: exynos5-usbdrd: support SS combo phy for > ExynosAutov920 > > On 18-08-25, 13:11, Pritam Manohar Sutar wrote: > > > > > + /* check cr_para_ack*/ > > > > + cnt = 0; > > > > + do { > > > > + /* > > > > + * data symbols are captured by phy on rising edge of the > > > > + * tx_clk when tx data enabled. > > > > + * completion of the write cycle is acknowledged by > > assertion > > > > + * of the cr_para_ack. > > > > + */ > > > > + exynosautov920_usb31drd_cr_clk(phy_drd, true); > > > > + reg = readl(reg_phy + > > > EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0); > > > > + if ((reg & PHY_CR_PARA_CON0_PHY0_CR_PARA_ACK)) > > > > + break; > > > > + > > > > + exynosautov920_usb31drd_cr_clk(phy_drd, false); > > > > + > > > > + /* > > > > + * wait for minimum of 10 cr_para_clk cycles after phy reset > > > > + * is negated, before accessing control regs to allow for > > > > + * internal resets. > > > > + */ > > > > + cnt++; > > > > + } while (cnt < 10); > > > > + > > > > + if (cnt == 10) > > > > + dev_dbg(dev, "CR write failed to 0x%04x\n", addr); > > > > > > Not error? > > > > This is only for debugging purpose. It is not considered as error. > > Write failed is not an error? If this code is only for debug, pls drop it. Sure. will drop it. > > -- > ~Vinod Regards, Pritam -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy