From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <quic_jingyw@quicinc.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Xin Liu <quic_liuxin@quicinc.com>
Subject: Re: [PATCH v2] dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300
Date: Wed, 25 Sep 2024 09:14:00 +0200 [thread overview]
Message-ID: <01ea36e7-f4a7-4f1f-9596-3ed6ed13b47b@kernel.org> (raw)
In-Reply-To: <6656171b-12d3-490b-b53c-f907b7454f99@quicinc.com>
On 25/09/2024 05:16, Jingyi Wang wrote:
>
>
> On 9/16/2024 10:53 PM, Krzysztof Kozlowski wrote:
>> On Wed, Sep 11, 2024 at 02:56:16PM +0800, Jingyi Wang wrote:
>>> From: Xin Liu <quic_liuxin@quicinc.com>
>>>
>>> Document the QMP UFS PHY compatible for Qualcomm QCS8300 to support
>>> physical layer functionality for UFS found on the SoC. Use fallback to
>>> indicate the compatibility of the QMP UFS PHY on the QCS8300 with that
>>> on the SA8775P.
>>>
>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>>> ---
>>> Changes in v2:
>>> - decoupled from the original series.
>>> - Use fallback to indicate compatibility with SA8775P.
>>> - typo fixup
>>> - Link to v1: https://lore.kernel.org/r/20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com
>>> ---
>>> .../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 46 ++++++++++++----------
>>> 1 file changed, 26 insertions(+), 20 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>>> index f9cfbd0b2de6..626a2039e177 100644
>>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>>> @@ -15,26 +15,31 @@ description:
>>>
>>> properties:
>>> compatible:
>>> - enum:
>>> - - qcom,msm8996-qmp-ufs-phy
>>> - - qcom,msm8998-qmp-ufs-phy
>>> - - qcom,sa8775p-qmp-ufs-phy
>>> - - qcom,sc7180-qmp-ufs-phy
>>> - - qcom,sc7280-qmp-ufs-phy
>>> - - qcom,sc8180x-qmp-ufs-phy
>>> - - qcom,sc8280xp-qmp-ufs-phy
>>> - - qcom,sdm845-qmp-ufs-phy
>>> - - qcom,sm6115-qmp-ufs-phy
>>> - - qcom,sm6125-qmp-ufs-phy
>>> - - qcom,sm6350-qmp-ufs-phy
>>> - - qcom,sm7150-qmp-ufs-phy
>>> - - qcom,sm8150-qmp-ufs-phy
>>> - - qcom,sm8250-qmp-ufs-phy
>>> - - qcom,sm8350-qmp-ufs-phy
>>> - - qcom,sm8450-qmp-ufs-phy
>>> - - qcom,sm8475-qmp-ufs-phy
>>> - - qcom,sm8550-qmp-ufs-phy
>>> - - qcom,sm8650-qmp-ufs-phy
>>> + oneOf:
>>> + - items:
>>> + - enum:
>>> + - qcom,qcs8300-qmp-ufs-phy
>>> + - const: qcom,sa8775p-qmp-ufs-phy
>>> + - enum:
>>> + - qcom,msm8996-qmp-ufs-phy
>>> + - qcom,msm8998-qmp-ufs-phy
>>> + - qcom,sa8775p-qmp-ufs-phy
>>> + - qcom,sc7180-qmp-ufs-phy
>>> + - qcom,sc7280-qmp-ufs-phy
>>> + - qcom,sc8180x-qmp-ufs-phy
>>> + - qcom,sc8280xp-qmp-ufs-phy
>>> + - qcom,sdm845-qmp-ufs-phy
>>> + - qcom,sm6115-qmp-ufs-phy
>>> + - qcom,sm6125-qmp-ufs-phy
>>> + - qcom,sm6350-qmp-ufs-phy
>>> + - qcom,sm7150-qmp-ufs-phy
>>> + - qcom,sm8150-qmp-ufs-phy
>>> + - qcom,sm8250-qmp-ufs-phy
>>> + - qcom,sm8350-qmp-ufs-phy
>>> + - qcom,sm8450-qmp-ufs-phy
>>> + - qcom,sm8475-qmp-ufs-phy
>>> + - qcom,sm8550-qmp-ufs-phy
>>> + - qcom,sm8650-qmp-ufs-phy
>>>
>>> reg:
>>> maxItems: 1
>>> @@ -85,6 +90,7 @@ allOf:
>>> contains:
>>> enum:
>>> - qcom,msm8998-qmp-ufs-phy
>>> + - qcom,qcs8300-qmp-ufs-phy
>>
>> Not needed.
>>
> Well noted.
>> BTW, please be sure you organize your patchsets per subsystem. IOW, that
>> you do not split same subsystem bindings patches into separate
>> patchsets.
>>
> Do you mean combine the binding of qmp-ufs-phy with ufs controller? I noticed
> that this patch belongs to "GENERIC PHY FRAMEWORK" subsystem and ufs controller
> binding belongs to "UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER". If necessary,
> we can pay attention to combine them next time
No, I mean group patches targeting the same subsystem.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2024-09-25 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 6:56 [PATCH v2] dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300 Jingyi Wang
2024-09-16 14:53 ` Krzysztof Kozlowski
2024-09-25 3:16 ` Jingyi Wang
2024-09-25 7:14 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ea36e7-f4a7-4f1f-9596-3ed6ed13b47b@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=quic_jingyw@quicinc.com \
--cc=quic_liuxin@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).