Re: [PATCH 2/7] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY

Krzysztof Kozlowski
2025-04-07T13:20:21Z

On 07/04/2025 14:38, Ze Huang wrote:
> Introduce support for SpacemiT K1 PCIe/USB3 combo PHY controller.
>
> PCIe portA and USB3 controller share this phy, only one of them can work
> at any given application scenario.
>
> Signed-off-by: Ze Huang <huangze@whut.edu.cn>
> ---
> .../bindings/phy/spacemit,k1-combphy.yaml | 53 ++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/spacemit,k1-combphy.yaml b/Documentation/devicetree/bindings/phy/spacemit,k1-combphy.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..450157b65410b27129603ea1f3523776a1b0a75e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/spacemit,k1-combphy.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/spacemit,k1-combphy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Spacemit K1 PCIe/USB3 PHY
> +
> +maintainers:
> + - Ze Huang <huangze@whut.edu.cn>
> +
> +description:
> + Combo PHY on SpacemiT K1 SoC.PCIe port A and USB3 controller share this
> + phy, only one of PCIe port A and USB3 port can work at any given application
> + scenario.
> +
> +properties:
> + compatible:
> + const: spacemit,k1-combphy
> +
> + reg:
> + maxItems: 2

List and describe the items instead

> +
> + reg-names:
> + items:
> + - const: phy_ctrl

drop phy_

> + - const: phy_sel

ditto

> +
> + resets:
> + maxItems: 1
> +
> + "#phy-cells":
> + const: 1

What is the cell argument?

Also no supplies?

>

Best regards,
Krzysztof