Re: [PATCH 3/7] dt-bindings: usb: add SpacemiT K1 DWC3 glue

Ze Huang
2025-04-09T08:31:57Z

On 4/7/25 9:51 PM, Rob Herring (Arm) wrote:
> On Mon, 07 Apr 2025 20:38:48 +0800, Ze Huang wrote:
>> Add support for SpacemiT DWC3 glue driver, which manages interrupt,
>> reset and clock resource.
>>
>> Signed-off-by: Ze Huang <huangze@whut.edu.cn>
>> ---
>> .../devicetree/bindings/usb/spacemit,k1-dwc3.yaml | 78 ++++++++++++++++++++++
>> 1 file changed, 78 insertions(+)
>>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/spacemit,k1-dwc3.example.dtb: usb@c0a00000 (spacemit,k1-dwc3): '#address-cells', '#size-cells' do not match any of the regexes: '^usb@', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/usb/spacemit,k1-dwc3.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/spacemit,k1-dwc3.example.dtb: usb@c0a00000 (spacemit,k1-dwc3): usb@0:reg: [[0, 0], [0, 65536]] is too long
> from schema $id: http://devicetree.org/schemas/usb/spacemit,k1-dwc3.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/spacemit,k1-dwc3.example.dtb: usb@0 (snps,dwc3): reg: [[0, 0], [0, 65536]] is too long
> from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#

Thanks for the report!
I’ll add '#address-cells' and '#size-cells' under properties to resolve
the error.
because if I drop them from the example, I get warnings like:

Warning (avoid_default_addr_size): /example-0/usb@c0a00000/usb@0:
Relying on default #address-cells value

>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250407-b4-k1-usb3-v3-2-v1-3-bf0bcc41c9ba@whut.edu.cn
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.