From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Vinod Koul'" <vkoul@kernel.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 3/6] phy: samsung: ufs: support secondary ufs phy
Date: Thu, 2 Jun 2022 21:59:51 +0900 [thread overview]
Message-ID: <050301d87680$a5dac8e0$f1905aa0$@samsung.com> (raw)
In-Reply-To: <42b8c793-caa7-e14d-0a6c-dec7aa914dff@linaro.org>
> > + phy->isol = devm_kzalloc(dev, sizeof(struct pmu_isol), GFP_KERNEL);
>
> 1. Looks like devm_kmemdup
> 2. sizeof(*variable), not sizeof(struct)
>
> 3. and actually you can simplify all that by storing struct pmu_isol
> directly in struct samsung_ufs_phy, not as pointer.
>
> After all that storing drvdata in samsung_ufs_phy does not make any sense
> - only one field is left still used (has_symbol_clk), so this should be
> simplified here as well.
It would be better storing struct pmu_isol directly and remove drvdata from samsung_ufs_phy as you suggested.
Furthermore, definition of struct pmu_isol looks odd in the definition of samsung_ufs_phy_drvdata.
So, I'll pop it out and change the naming to "struct samsung_ufs_phy_pmu_isol"
Best Regards,
Chanho Park
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-06-02 13:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220602053329epcas2p402901736895e6cb802a04cc3f95d172e@epcas2p4.samsung.com>
2022-06-02 5:32 ` [PATCH v2 0/6] support secondary ufs for Exynos Auto v9 SoC Chanho Park
2022-06-02 5:32 ` [PATCH v2 1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Chanho Park
2022-06-02 9:34 ` Krzysztof Kozlowski
2022-06-02 9:37 ` Krzysztof Kozlowski
2022-06-02 10:10 ` Chanho Park
2022-06-02 11:42 ` Krzysztof Kozlowski
2022-06-02 5:32 ` [PATCH v2 2/6] phy: samsung: ufs: constify samsung_ufs_phy_cfg Chanho Park
2022-06-02 9:42 ` Krzysztof Kozlowski
2022-06-02 13:04 ` Chanho Park
2022-06-03 7:25 ` Krzysztof Kozlowski
2022-06-02 5:32 ` [PATCH v2 3/6] phy: samsung: ufs: support secondary ufs phy Chanho Park
2022-06-02 9:49 ` Krzysztof Kozlowski
2022-06-02 12:59 ` Chanho Park [this message]
2022-06-02 5:32 ` [PATCH v2 4/6] arm64: dts: exynosautov9: adjust DT style of ufs nodes Chanho Park
2022-06-02 9:49 ` Krzysztof Kozlowski
2022-06-06 9:22 ` Krzysztof Kozlowski
2022-06-07 5:21 ` Chanho Park
2022-06-07 6:33 ` Krzysztof Kozlowski
2022-06-07 6:48 ` Chanho Park
2022-06-07 6:32 ` (subset) " Krzysztof Kozlowski
2022-06-02 5:32 ` [PATCH v2 5/6] arm64: dts: exynosautov9: add secondary ufs devices Chanho Park
2022-06-02 5:32 ` [PATCH v2 6/6] arm64: dts: exynosautov9-sadk: enable " Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='050301d87680$a5dac8e0$f1905aa0$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).