From: Krzysztof Kozlowski <krzk@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>,
Rob Herring <robh@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jack Zhu <jack.zhu@starfivetech.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx
Date: Fri, 7 Apr 2023 08:54:06 +0200 [thread overview]
Message-ID: <06a17138-cccc-1283-d235-fa54275c1651@kernel.org> (raw)
In-Reply-To: <fa13e903-809d-064f-baff-c7e7474b52da@starfivetech.com>
On 07/04/2023 08:51, Changhuang Liang wrote:
>>> +
>>> + resets:
>>> + items:
>>> + - description: DPHY_HW reset
>>> + - description: DPHY_B09_ALWAYS_ON reset
>>> +
>>> + starfive,aon-syscon:
>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>>> + items:
>>> + - items:
>>> + - description: phandle of AON SYSCON
>>> + - description: register offset
>>> + description: The power of dphy rx is configured by AON SYSCON
>>> + in this property.
>>
>> Sounds like AON SYSCON should be a power-domains provider. Custom
>> phandle links are for things which don't fit standard bindings.
>>
>
> Hi, Rob,
>
> On visionfive2 jh7110 SoC, this AON SYSCON is the Secondary power switch to the DPHY Rx.
> When we open the pmic switch, we also need to configure the AON SYSCON register to turn
> on the switch, it is used to link the pmic and the DPHY Rx, So I think it just use syscon
> framework is enought. What about your comments.
Which sounds exactly like power domain provider...
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-04-07 6:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 10:04 [PATCH v3 0/3] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-03-15 10:04 ` [PATCH v3 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx Changhuang Liang
2023-03-20 15:14 ` Rob Herring
2023-03-21 1:56 ` Changhuang Liang
2023-04-07 6:51 ` Changhuang Liang
2023-04-07 6:54 ` Krzysztof Kozlowski [this message]
2023-04-07 6:58 ` Changhuang Liang
2023-03-15 10:04 ` [PATCH v3 2/3] phy: starfive: Add mipi dphy rx support Changhuang Liang
2023-03-15 10:04 ` [PATCH v3 3/3] riscv: dts: starfive: Add dphy rx node Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a17138-cccc-1283-d235-fa54275c1651@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=changhuang.liang@starfivetech.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).