From: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback
Date: Tue, 10 Feb 2026 18:19:45 +0800 [thread overview]
Message-ID: <08cec7fc-a3da-4879-857a-32dd65c34311@oss.qualcomm.com> (raw)
In-Reply-To: <200b055b-7221-45b5-aea1-2462e07a3c1c@oss.qualcomm.com>
On 2/6/2026 6:52 PM, Konrad Dybcio wrote:
> On 2/5/26 10:20 AM, Yongxing Mou wrote:
>> Introduce the com_ldo_config callback to support per‑PHY LDO
>> configuration.
>>
>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>> ---
>
> [...]
>
>> +static int qcom_edp_ldo_config_v4(const struct qcom_edp *edp)
>> +{
>> + const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts;
>> + u32 ldo_config;
>> +
>> + if (!edp->is_edp)
>> + ldo_config = 0x0;
>> + else if (dp_opts->link_rate <= 2700)
>> + ldo_config = 0xC1;
>
> lowercase hex, please
>
Got it. will fix next version
>> + else
>> + ldo_config = 0x81;
>> +
>> + writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG);
>> + writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG);
>
> tx1 should be dp_ops->lanes ? 2 : ldo_config : 0x00, in all cases,
> I believe
>
> Konrad
i check the HPG, yes , here need to consider dp_ops->lanes.. will fix it
next patch.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-02-10 10:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 9:20 [PATCH 0/3] phy: qcom: edp: Add DP/eDP switch for phys Yongxing Mou
2026-02-05 9:20 ` [PATCH 1/3] phy: qcom: edp: Correct and clean up eDP/DP combo PHY configuration values Yongxing Mou
2026-02-06 10:47 ` Konrad Dybcio
2026-02-09 9:00 ` Yongxing Mou
2026-02-09 12:46 ` Dmitry Baryshkov
2026-02-10 6:13 ` Yongxing Mou
2026-02-13 11:08 ` Konrad Dybcio
2026-02-07 10:22 ` Dmitry Baryshkov
2026-02-09 9:52 ` Yongxing Mou
2026-02-09 12:47 ` Dmitry Baryshkov
2026-02-10 10:17 ` Yongxing Mou
2026-02-10 12:33 ` Dmitry Baryshkov
2026-02-05 9:20 ` [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback Yongxing Mou
2026-02-06 10:52 ` Konrad Dybcio
2026-02-10 10:19 ` Yongxing Mou [this message]
2026-02-12 9:04 ` Yongxing Mou
2026-02-13 11:14 ` Konrad Dybcio
2026-02-25 7:21 ` Yongxing Mou
2026-02-07 10:17 ` Dmitry Baryshkov
2026-02-10 10:21 ` Yongxing Mou
2026-02-05 9:20 ` [PATCH 3/3] phy: qcom: edp: Add eDP phy mode switch support Yongxing Mou
2026-02-06 11:02 ` Konrad Dybcio
2026-02-10 10:29 ` Yongxing Mou
2026-02-13 11:06 ` Konrad Dybcio
2026-02-25 8:00 ` Yongxing Mou
2026-02-07 10:20 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08cec7fc-a3da-4879-857a-32dd65c34311@oss.qualcomm.com \
--to=yongxing.mou@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox