From: Monish Chunara <monish.chunara@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Ulf Hansson <ulfh@kernel.org>,
Kernel Team <kernel@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-mmc@vger.kernel.org,
Nitin Rawat <nitin.rawat@oss.qualcomm.com>,
Pradeep Pragallapati <pradeep.pragallapati@oss.qualcomm.com>,
Komal Bajaj <komal.bajaj@oss.qualcomm.com>
Subject: Re: [PATCH V2 1/2] arm64: dts: qcom: Add SD Card support for Shikra SoC
Date: Thu, 2 Jul 2026 12:22:57 +0530 [thread overview]
Message-ID: <08ed6b4d-5549-4aae-9967-1365db0e3aa2@oss.qualcomm.com> (raw)
In-Reply-To: <b43691aa-6d1e-4df0-9d1a-cd5c4b3e3dff@oss.qualcomm.com>
On 7/1/2026 5:07 PM, Konrad Dybcio wrote:
> On 6/30/26 6:56 PM, Monish Chunara wrote:
>> Add support for SD card on Shikra SoC and enable the required pinctrl
>> configurations.
>>
>> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
>> ---
>
> [...]
>
>> + sdhc_2: mmc@4784000 {
>> + compatible = "qcom,shikra-sdhci", "qcom,sdhci-msm-v5";
>> + reg = <0x0 0x4784000 0x0 0x1000>;
>
> Please pad the address part of reg to 8 hex digits with leading
> zeroes, like all the other nodes
>
> otherwise
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Konrad
>
ACK, Thanks. Will rectify in v3.
Regards,
Monish
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-07-02 6:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 16:56 [PATCH V2 0/2] arm64: dts: qcom: Shikra SD Card support Monish Chunara
2026-06-30 16:56 ` [PATCH V2 1/2] arm64: dts: qcom: Add SD Card support for Shikra SoC Monish Chunara
2026-07-01 11:37 ` Konrad Dybcio
2026-07-02 6:52 ` Monish Chunara [this message]
2026-06-30 16:57 ` [PATCH V2 2/2] arm64: dts: qcom: Enable SD card for Shikra EVK Monish Chunara
2026-07-01 11:38 ` Konrad Dybcio
2026-07-02 6:54 ` Monish Chunara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08ed6b4d-5549-4aae-9967-1365db0e3aa2@oss.qualcomm.com \
--to=monish.chunara@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=komal.bajaj@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=nitin.rawat@oss.qualcomm.com \
--cc=pradeep.pragallapati@oss.qualcomm.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=ulfh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox