From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30DC9C6FD18 for ; Tue, 25 Apr 2023 09:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yfogPEIB9WM1gZQ4jYSZ+3EqiHY8GZZTNLfEFSVIvVI=; b=h5CR5uSFTeEP5w 6AWiOuHuT+zHSywZNNkCXIGldN3VdCFcojBnge+3gRommU5tBfirSbxqC7fZ//98fLQ2qUDy96vnO 0COoEIjkf17OYx+73JmsU+gnuJKdmyWHN4z1M0kcK23f3fpzakGO+Popkq8j0Tz6UEj0xgz69tyx3 aFVPmCU+IcCFCKN0OosuOpFlOadxEMFoks54hCIr1MSvpJ/TgjzdUYzeTx5j9B3rEtFkhf41BdCYg 4qIoS/kTie2O8ito6WMeYAtfNbpUtgw/Isnrv8mpuN8em6hCtEoZreZlIBnDDStnF7nFxBOkyW8YP vVFvrdGRxPXmh8VXTJpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prEoq-000d2p-2h; Tue, 25 Apr 2023 09:18:40 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prEon-000d12-0g; Tue, 25 Apr 2023 09:18:39 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 9FC5524E314; Tue, 25 Apr 2023 17:18:11 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 25 Apr 2023 17:18:12 +0800 Received: from [192.168.125.106] (113.72.145.137) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 25 Apr 2023 17:18:10 +0800 Message-ID: <0988495f-b87a-7f69-f222-37c67d6eae23@starfivetech.com> Date: Tue, 25 Apr 2023 17:18:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support Content-Language: en-US To: Krzysztof Kozlowski , Conor Dooley CC: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , , , References: <20230419035646.43702-1-changhuang.liang@starfivetech.com> <20230419035646.43702-2-changhuang.liang@starfivetech.com> <20230419-labored-camper-644d51a7ca96@spud> <1a5b15fa-4f20-51c2-2ba1-a04a2911a694@starfivetech.com> <20230424-baffle-punch-ec73098f2b6a@spud> <20230425-unquote-eligible-09f743d81981@wendy> <68cb565d-bf39-10b0-9e3e-35ba7f54b90b@linaro.org> From: Changhuang Liang In-Reply-To: <68cb565d-bf39-10b0-9e3e-35ba7f54b90b@linaro.org> X-Originating-IP: [113.72.145.137] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230425_021837_555660_B87982CA X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 2023/4/25 16:19, Krzysztof Kozlowski wrote: > On 25/04/2023 09:57, Changhuang Liang wrote: >>>>>>>> >>>>>>>> description: | >>>>>>>> StarFive JH7110 SoC includes support for multiple power domains which can be >>>>>>>> @@ -17,6 +18,7 @@ properties: >>>>>>>> compatible: >>>>>>>> enum: >>>>>>>> - starfive,jh7110-pmu >>>>>>>> + - starfive,jh7110-aon-pmu >>>>> >>>>> I was speaking to Rob about this over the weekend, he asked: >>>>> 'Why isn't "starfive,jh7110-aon-syscon" just the power-domain provider >>>>> itself?' >>>> >>>> Maybe not, this syscon only offset "0x00" configure power switch. >>>> other offset configure other functions, maybe not power, so this >>>> "starfive,jh7110-aon-syscon" not the power-domain itself. >>>> >>>>> Do we actually need to add a new binding for this at all? >>>>> >>>>> Cheers, >>>>> Conor. >>>>> >>>> >>>> Maybe this patch do that. >>>> https://lore.kernel.org/all/20230414024157.53203-6-xingyu.wu@starfivetech.com/ >>> >>> This makes it a child-node right? I think Rob already said no to that in >>> and earlier revision of this series. What he meant the other day was >>> making the syscon itself a power domain controller, since the child node >>> has no meaningful properties (reg, interrupts etc). >>> >>> Cheers, >>> Conor. >> >> Yes, "starfive,jh7110-aon-pmu" is a child-node of "starfive,jh7110-aon-syscon". >> In my opinion, "0x17010000" is "aon-syscon" on JH7110 SoC, and this "aon-pmu" is just >> a part of "aon-syscon" function, so I think it is inappropriate to make "aon-syscon" >> to a power domain controller. I think using the child-node description is closer to >> JH7110 SoC. > > Unfortunately, I do not see the correlation between these, any > connection. Why being a child of syscon block would mean that this > should no be power domain controller? Really, why? These are two > unrelated things. > > Best regards, > Krzysztof > Let me summarize what has been discussed above. There has two ways to describe this "starfive,jh7110-aon-syscon"(0x17010000). 1. (0x17010000) is power-controller node: aon_pwrc: power-controller@17010000 { compatible = "starfive,jh7110-aon-pmu", "syscon"; reg = <0x0 0x17010000 0x0 0x1000>; #power-domain-cells = <1>; }; 2. (0x17010000) is syscon node, power-controller is child-node of syscon: aon_syscon: syscon@17010000 { compatible = "starfive,jh7110-aon-syscon", "syscon", "simple-mfd"; reg = <0x0 0x17010000 0x0 0x1000>; aon_pwrc: power-controller { compatible = "starfive,jh7110-aon-pmu"; #power-domain-cells = <1>; }; }; I prefer the way of 2. This is more in line with the hardware description of JH7110. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy