From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 319C1C98302 for ; Tue, 22 Sep 2026 12:14:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=seCVj2DOs8COghoY0MKiT9CSJyt5pjIW2QZxJ5wB9BE=; b=awJzNOsAPq4wUMIZotIK6ay+yt 5WBUfh0mMgT7HKVBmycBt0tnTk6rydOw3fkqyp4lJGYGIU3BljHv5ain52hJ65ol2vaKT1PWPPj/4 exy8w9AHQv3JY7oTHgn41dS1Bl92UyW1GddROErQHaZKyAON0qpy0mMMAVqhisqOV7svt5iKaPMpi Rs7M4IAd4u3o4Ndy/akuseuDp1+6CMszuMhUVrUKmxN/cJ5UBdcNMLFEQEE5iY+JRM4rT1plDxrw/ dMBvkPZ5drrHXoWi1TGTR3GhR8cSrUmm0Kw3yTc+XaOoejQa3K+N6hIzGXMfZ7kyoNCgf4RYybnDJ Ogp2/0zQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8zO0-00000005H90-2lwP; Tue, 22 Sep 2026 12:14:12 +0000 Received: from mail-wm2-x10.google.com ([2a00:1450:4864:31::10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8zNy-00000005H8V-3lWE for linux-phy@lists.infradead.org; Tue, 22 Sep 2026 12:14:12 +0000 Received: by mail-wm2-x10.google.com with SMTP id 5b1f17b1804b1-49b912e4ad9so23838875e9.2 for ; Tue, 22 Sep 2026 05:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1790079248; x=1790684048; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=439w0jXQDSVQ/YyUnnVLCmsM8bZ02DVBQwb7bD5E5+c=; b=thUpb3SmR5863yNnk8bknR+eXM3wUQZUSVM0lcZliG2B2Wx3MaX3nfNLBQQVDJQxEG 9zDRJSE2VEjPsPPu/V/PQijjhAZPivyUKPW5ZjzYuvy4R/ZpnrmREvzfa/6bP8MFZL11 k6M9LROxfQV/xevzFhUAFLen6IHxK7b2Ctu1LGh54o3HqamPslAHjOey7YcvhrXOJMXH QN7SMTZl1PTgWQEEyNWpP3gXvOiP2ozG6EqUz0LBFrGBE+VaR2YDRsqd6KeT2SXcJsBQ E/2BzbME3TbljSyjOMonYey8E0YVhTDmlQH8wLo/+QzmB4GyE0AAdN286tgPI859KGPZ xFiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790079248; x=1790684048; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=439w0jXQDSVQ/YyUnnVLCmsM8bZ02DVBQwb7bD5E5+c=; b=1rJJP4rxGVbLm077FJf8eT/iGJReLEKffdDeqp6GUWpFNi1Iy2UbQDL95aUgOAOnpy Tgf/7/+WjC3mH9uqHUdpK+oi2WgiqoDyvQrzjcXfuNrf8HBLNOrVa8QTkH3gRvga5tXJ MDIKH5q3Kg/raFM1xEhGb0twXJBQceHLIOaV9qaHxd9r7z9eLn9NuoCkqSWhgvh/a9Bm MxJ8A4sqMDye8eqowJDfVHBuOHm1Zxb1X7aeIzq9RLd9oNfa9tYutbjiF3GVDm0ZDHLY QpmGq47QZMwUJuynN+jT6TlB1GPIekDlUtLfOGNapP1hdjtorx9FHUC1HKamzcegHdKq aRZQ== X-Forwarded-Encrypted: i=1; AKwUvBzEA9ypdUkeMOqi1p14W764wQFpHjlz4LCuZhVW9LmxZ/w5HyzMqRkTGM7Ixxy4ulQKjoZJFiWYfP4=@lists.infradead.org X-Gm-Message-State: AFuF++lnLBrwDku5d6eT8baDzY5nRz9kCDktHSBvz/wSdbm/KWBLluAd gIYoLbGql3exH5DFrarjeVht+jI4my0dHxrydvoEGni1sNY+ArcmZHArA5c5PMytK5s= X-Gm-Gg: AYBFou0lLUpl74yxhROCQYuYzv+0wpSb7pQwC+WMITPbGQ+cWQj0v/h3m+0c6SPeEHC 0afkwzZwoRb33+j+2FlIZTczMe37Ns8hCchk084lOSjDNgu5oQmI1wYE4DStDbzWxslXY0CniXx CLVEOX62fhPKaKNYA5GjiQ2ABVFXR7tdIiKjhociob2h25M+NB1j2UbHWf0POyo23B/vaFo3hlS nxg/JOwpwUL41FHunAPKr/vXnOv22adf/S2nXOs9ClzS3uI8eUnuLryxHK2NdRd0h/WEUxdo79V LU3dUCNuRPuK3/sglWJDBtCNxmKVSeGiI5XzD5Lt6qXyirFiHqVqaExRfhUAyHpVYgGTzH7eBC0 GdQ2WSbH2NJiUo6Gsy1HmA58gkXqMl3DNPwTb9oH9TN3HM2eOGpAJjWMIU/tHXgv45wAr8iJ2// yOd7sDUQEJaxyomqhCOrQPPiWghY4U9J4MlCAFX4QyFNUJA+waXOvw1I8quUML6Ny6fJvEahfSr EFvHifWcU5OppPQrxUkdU1Y+CX9t+vpOO12rew0ogdqWs4JrW43Y+pg6bS5VR6h X-Received: by 2002:a05:600c:354e:b0:49c:fc6e:a3d8 with SMTP id 5b1f17b1804b1-49fc584f854mr189068335e9.23.1790079247126; Tue, 22 Sep 2026 05:14:07 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:ddd0:8cc7:9887:fa82? ([2a01:e0a:106d:1080:ddd0:8cc7:9887:fa82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fd8cd5214sm80191765e9.9.2026.09.22.05.14.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2026 05:14:06 -0700 (PDT) Message-ID: <0a9bfc33-057d-4ce0-9b00-b1fafcf0da03@linaro.org> Date: Tue, 22 Sep 2026 14:14:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v20 2/6] phy: core: Add phy_get_by_of_node() To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , Bryan O'Donoghue , Loic Poulain , Vinod Koul , Greg Kroah-Hartman , Kishon Vijay Abraham I , Felipe Balbi , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-phy@lists.infradead.org, Krzysztof Kozlowski References: <20260918-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v20-0-dc244e124e71@linaro.org> <20260918-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v20-2-dc244e124e71@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260918-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v20-2-dc244e124e71@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260922_051410_997403_CEA096E3 X-CRM114-Status: GOOD ( 22.62 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 9/18/26 15:56, Bryan O'Donoghue wrote: > Add new function phy_get_by_of_node() allowing lookup of a phy by > device_node. Separates existing logic in _of_phy_get() into an internal > helper method _of_phy_get_with_args() to allow for reuse in new method. > > Signed-off-by: Bryan O'Donoghue > --- > drivers/phy/phy-core.c | 83 ++++++++++++++++++++++++++++++++++++++----------- > include/linux/phy/phy.h | 6 ++++ > 2 files changed, 71 insertions(+), 18 deletions(-) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index 89addd732bff3..42c27a2b45159 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -606,6 +606,38 @@ int phy_validate(struct phy *phy, enum phy_mode mode, int submode, > } > EXPORT_SYMBOL_GPL(phy_validate); > > +/** > + * _of_phy_get_with_args() - lookup and obtain a reference to a phy by of_phandle_args > + * @args: of_phandle_args to the phy > + * > + * Returns: the phy from the provider's of_xlate, -ENODEV if disabled, > + * -EPROBE_DEFER if the provider is not yet registered. > + */ > +static struct phy *_of_phy_get_with_args(struct of_phandle_args *args) > +{ > + struct phy *phy; > + struct phy_provider *phy_provider; > + > + lockdep_assert_held(&phy_provider_mutex); > + > + phy_provider = of_phy_provider_lookup(args->np); > + if (IS_ERR(phy_provider) || !try_module_get(phy_provider->owner)) > + return ERR_PTR(-EPROBE_DEFER); > + > + if (!of_device_is_available(args->np)) { > + dev_warn(phy_provider->dev, "Requested PHY is disabled\n"); > + phy = ERR_PTR(-ENODEV); > + goto out_put_module; > + } > + > + phy = phy_provider->of_xlate(phy_provider->dev, args); > + > +out_put_module: > + module_put(phy_provider->owner); > + > + return phy; > +} > + > /** > * _of_phy_get() - lookup and obtain a reference to a phy by phandle > * @np: device_node for which to get the phy > @@ -620,8 +652,7 @@ EXPORT_SYMBOL_GPL(phy_validate); > static struct phy *_of_phy_get(struct device_node *np, int index) > { > int ret; > - struct phy_provider *phy_provider; > - struct phy *phy = NULL; > + struct phy *phy; > struct of_phandle_args args; > > lockdep_assert_held(&phy_provider_mutex); > @@ -637,22 +668,7 @@ static struct phy *_of_phy_get(struct device_node *np, int index) > goto out_put_node; > } > > - phy_provider = of_phy_provider_lookup(args.np); > - if (IS_ERR(phy_provider) || !try_module_get(phy_provider->owner)) { > - phy = ERR_PTR(-EPROBE_DEFER); > - goto out_put_node; > - } > - > - if (!of_device_is_available(args.np)) { > - dev_warn(phy_provider->dev, "Requested PHY is disabled\n"); > - phy = ERR_PTR(-ENODEV); > - goto out_put_module; > - } > - > - phy = phy_provider->of_xlate(phy_provider->dev, &args); > - > -out_put_module: > - module_put(phy_provider->owner); > + phy = _of_phy_get_with_args(&args); > > out_put_node: > of_node_put(args.np); > @@ -1001,6 +1017,37 @@ struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np, > } > EXPORT_SYMBOL_GPL(devm_of_phy_get_by_index); > > +/** > + * phy_get_by_of_node() - lookup and obtain a reference to a phy by device_node > + * @np: node containing the phy > + * > + * Returns: the phy associated with the device node or ERR_PTR. > + */ > +struct phy *phy_get_by_of_node(struct device_node *np) > +{ > + struct of_phandle_args args = { .np = np, .args_count = 0 }; > + struct phy *phy; > + > + mutex_lock(&phy_provider_mutex); > + > + phy = _of_phy_get_with_args(&args); > + if (IS_ERR(phy)) > + goto out_unlock; > + > + if (!try_module_get(phy->ops->owner)) { > + phy = ERR_PTR(-EPROBE_DEFER); > + goto out_unlock; > + } > + > + get_device(&phy->dev); > + > +out_unlock: > + mutex_unlock(&phy_provider_mutex); > + > + return phy; > +} > +EXPORT_SYMBOL_GPL(phy_get_by_of_node); > + > /** > * phy_create() - create a new phy > * @dev: device that is creating the new phy > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index ea47975e288ae..71c2e16397130 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -284,6 +284,7 @@ struct phy *devm_of_phy_optional_get(struct device *dev, struct device_node *np, > const char *con_id); > struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np, > int index); > +struct phy *phy_get_by_of_node(struct device_node *np); > void of_phy_put(struct phy *phy); > void phy_put(struct device *dev, struct phy *phy); > void devm_phy_put(struct device *dev, struct phy *phy); > @@ -493,6 +494,11 @@ static inline struct phy *devm_of_phy_get_by_index(struct device *dev, > return ERR_PTR(-ENOSYS); > } > > +static inline struct phy *phy_get_by_of_node(struct device_node *np) > +{ > + return ERR_PTR(-ENOSYS); > +} > + > static inline void of_phy_put(struct phy *phy) > { > } > Reviewed-by: Neil Armstrong Thanks, Neil -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy