From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Dimitri Fedrau <dimitri.fedrau@liebherr.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: add support for NXPs TJA1145 CAN transceiver
Date: Sun, 3 Aug 2025 11:40:28 +0200 [thread overview]
Message-ID: <0b4b8291-40cf-4faf-a79f-48c56677f9a2@kernel.org> (raw)
In-Reply-To: <20250731044824.GA3815@legfed1>
On 31/07/2025 06:48, Dimitri Fedrau wrote:
>>> +allOf:
>>> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
>>
>> Missing ref to transceiver properties. Look at other CAN bindings.
>>
> There is only one transceiver property(max-bitrate) which I don't need
> because the max-bitrate is known for the device. So why should I add it
> to the DT ?
> I'm only aware of CAN controller bindings making use of the transceiver
> property which I think is because the PHYs they are supporting with this
> are very simple which need no or little configuration to operate and the
> max-bitrate property is needed to limit the bitrate.
It's fine then, I guess.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-08-03 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 15:39 [PATCH 0/2] phy: add basic support for NXPs TJA1145 CAN transceiver Dimitri Fedrau via B4 Relay
2025-07-28 15:39 ` [PATCH 1/2] dt-bindings: phy: add " Dimitri Fedrau via B4 Relay
2025-07-30 7:35 ` Krzysztof Kozlowski
2025-07-31 4:48 ` Dimitri Fedrau
2025-08-03 9:40 ` Krzysztof Kozlowski [this message]
2025-07-28 15:39 ` [PATCH 2/2] phy: add basic " Dimitri Fedrau via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4b8291-40cf-4faf-a79f-48c56677f9a2@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=dimitri.fedrau@liebherr.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox