From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tzu-Hao Wei <twei@axiado.com>
Cc: SriNavmani A <srinavmani@axiado.com>,
Prasad Bolisetty <pbolisetty@axiado.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Harshit Shah <hshah@axiado.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Michal Simek <michal.simek@amd.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 0/8] Add Axiado AX3000 eMMC Host Controller Support
Date: Mon, 12 Jan 2026 09:33:47 +0100 [thread overview]
Message-ID: <0cc2b2a0-25ba-493e-9134-f109de922218@kernel.org> (raw)
In-Reply-To: <108cf065-e2ac-4ab7-9c39-6e52cb5439fa@axiado.com>
On 09/01/2026 10:48, Tzu-Hao Wei wrote:
> On 12/23/2025 10:33 PM, Krzysztof Kozlowski wrote:
>>
>> You completely disorganized the patch.. dts is mixed all over driver
>> code, you combined two or three completely independent subsystems into
>> one.
>>
>> Read submitting patches in DT dir to understand how DTS must be sent.
>>
>>
>> Best regards,
>> Krzysztof
>>
> Hi Krzysztof,
>
> Appreciate your review comments. We reorganized the patch series per your review comments, separating the DTS changes and applying the driver code changes to the respective subsystems as following
Please wrap your emails correctly.
> https://lore.kernel.org/all/20260109-axiado-ax3000-add-emmc-phy-driver-support-v1-0-dd43459dbfea@axiado.com/
You sent this as v1, which I noticed only now. If I knew you ignored my
feedback, I would not care to review again... Lesson for me.
> https://lore.kernel.org/all/20260109-axiado-ax3000-add-emmc-host-driver-support-v2-0-934f1a61f7c0@axiado.com/
>
> We will also sync up internally and tighten our review process to ensure this kind of mistake does not happen again in future submissions.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2026-01-12 8:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 8:44 [PATCH 0/8] Add Axiado AX3000 eMMC Host Controller Support Tzu-Hao Wei
2025-12-22 8:45 ` [PATCH 1/8] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY document Tzu-Hao Wei
2025-12-23 14:23 ` Krzysztof Kozlowski
2026-02-05 3:38 ` Tzu-Hao Wei
2025-12-23 14:23 ` Krzysztof Kozlowski
2026-02-05 3:36 ` Tzu-Hao Wei
2025-12-22 8:45 ` [PATCH 2/8] phy: axiado: add Arasan eMMC-PHY for Axiado Tzu-Hao Wei
2025-12-23 14:32 ` Krzysztof Kozlowski
2026-02-05 3:36 ` Tzu-Hao Wei
2025-12-22 8:45 ` [PATCH 3/8] arm64: dts: axiado: Add eMMC-PHY node support Tzu-Hao Wei
2025-12-22 8:45 ` [PATCH 4/8] MAINTAINERS: Update entry for Axiado eMMC PHY Tzu-Hao Wei
2025-12-22 8:45 ` [PATCH 5/8] dt-bindings: mmc: axiado: Add axiado eMMC variant Tzu-Hao Wei
2025-12-23 14:43 ` Krzysztof Kozlowski
2026-02-05 3:35 ` Tzu-Hao Wei
2025-12-27 12:50 ` Krzysztof Kozlowski
2026-02-05 3:35 ` Tzu-Hao Wei
2025-12-22 8:45 ` [PATCH 6/8] mmc: host: axiado: add AX3000 eMMC PHY support to sdhci-of-arasan Tzu-Hao Wei
2025-12-23 14:34 ` Krzysztof Kozlowski
2026-02-05 3:36 ` Tzu-Hao Wei
2026-02-05 9:47 ` Krzysztof Kozlowski
2025-12-22 8:45 ` [PATCH 7/8] arm64: dts: axiado: add common sdhci host node in dtsi Tzu-Hao Wei
2025-12-22 8:45 ` [PATCH 8/8] arm64: dts: axiado: enable sdhci host Tzu-Hao Wei
2025-12-23 14:34 ` Krzysztof Kozlowski
2025-12-23 14:33 ` [PATCH 0/8] Add Axiado AX3000 eMMC Host Controller Support Krzysztof Kozlowski
2026-01-09 9:48 ` Tzu-Hao Wei
2026-01-12 8:33 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cc2b2a0-25ba-493e-9134-f109de922218@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hshah@axiado.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=pbolisetty@axiado.com \
--cc=robh@kernel.org \
--cc=srinavmani@axiado.com \
--cc=twei@axiado.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox