From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
linux-phy@lists.infradead.org, Dragan Simic <dsimic@manjaro.org>
Cc: vkoul@kernel.org, kishon@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] phy: phy-rockchip-inno-usb2: Improve error handling while probing
Date: Wed, 21 Aug 2024 10:44:00 +0200 [thread overview]
Message-ID: <12869965.VsHLxoZxqI@diego> (raw)
In-Reply-To: <866445027a4f41165c872f494b04c218b6e67b09.1724225528.git.dsimic@manjaro.org>
Am Mittwoch, 21. August 2024, 09:37:55 CEST schrieb Dragan Simic:
> Improve error handling in the probe path by using function dev_err_probe()
> where appropriate, and by no longer using it rather pointlessly in one place
> that actually produces a single, hardcoded error code.
>
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
> @@ -1375,8 +1372,10 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
> rphy->irq = platform_get_irq_optional(pdev, 0);
> platform_set_drvdata(pdev, rphy);
>
> - if (!phy_cfgs)
> - return dev_err_probe(dev, -EINVAL, "phy configs are not assigned!\n");
> + if (!phy_cfgs) {
> + dev_err(dev, "phy configs are not assigned\n");
> + return -EINVAL;
> + }
>
> ret = rockchip_usb2phy_extcon_register(rphy);
> if (ret)
I really don't understand the rationale here. Using dev_err_probe here
is just fine and with that change you just introduce more lines of code
for exactly the same functionality?
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-08-21 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 7:37 [PATCH v2 0/3] Improve error handling in Rockchip Inno USB 2.0 PHY driver Dragan Simic
2024-08-21 7:37 ` [PATCH v2 1/3] phy: phy-rockchip-inno-usb2: Perform trivial code cleanups Dragan Simic
2024-08-21 8:39 ` Heiko Stübner
2024-08-21 8:53 ` Dragan Simic
2024-08-21 7:37 ` [PATCH v2 2/3] phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better Dragan Simic
2024-08-21 8:41 ` Heiko Stübner
2024-08-21 8:55 ` Dragan Simic
2024-08-21 11:17 ` Christophe JAILLET
2024-08-21 19:05 ` Dragan Simic
2024-08-21 7:37 ` [PATCH v2 3/3] phy: phy-rockchip-inno-usb2: Improve error handling while probing Dragan Simic
2024-08-21 8:44 ` Heiko Stübner [this message]
2024-08-21 9:09 ` Dragan Simic
2024-08-21 9:17 ` Heiko Stübner
2024-08-21 9:34 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12869965.VsHLxoZxqI@diego \
--to=heiko@sntech.de \
--cc=dsimic@manjaro.org \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).