From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/14] phy: qcom-qmp-combo: drop v4 reference-clock source
Date: Sat, 12 Nov 2022 14:43:38 +0300 [thread overview]
Message-ID: <14f01c33-dada-b66a-f81a-74b9028de18b@linaro.org> (raw)
In-Reply-To: <20221111092457.10546-4-johan+linaro@kernel.org>
On 11/11/2022 12:24, Johan Hovold wrote:
> The source clock for the reference clock should not be described by the
> devicetree and instead this relationship should be modelled in the clock
> driver.
Do we have a fix for the gcc driver?
>
> Drop the management of the source clock from the driver for SC8180X and
> SC8280XP. Note that support for the former is not yet in mainline.
>
> Also note that the binding has never been updated to describe the v4
> clocks for SC8180X.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> index 51a03ac05c91..e6c7cf723b19 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> @@ -947,7 +947,7 @@ static const char * const qmp_v3_phy_clk_l[] = {
> };
>
> static const char * const qmp_v4_phy_clk_l[] = {
> - "aux", "ref_clk_src", "ref", "com_aux",
> + "aux", "ref", "com_aux",
> };
>
> /* the primary usb3 phy on sm8250 doesn't have a ref clock */
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-11-12 11:48 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 9:24 [PATCH 00/14] phy: qcom-qmp-combo: fix sc8280xp binding (set 3/3) Johan Hovold
2022-11-11 9:24 ` [PATCH 01/14] dt-bindings: phy: qcom,qmp-usb3-dp: rename current bindings Johan Hovold
2022-11-11 15:15 ` Krzysztof Kozlowski
2022-11-11 9:24 ` [PATCH 02/14] dt-bindings: phy: qcom,qmp-usb3-dp: fix sc8280xp bindings Johan Hovold
2022-11-11 13:24 ` Johan Hovold
2022-11-11 13:30 ` Rob Herring
2022-11-11 15:17 ` Krzysztof Kozlowski
2022-11-14 13:27 ` Johan Hovold
2022-11-14 14:07 ` Krzysztof Kozlowski
2022-11-14 14:18 ` Johan Hovold
2022-11-14 15:19 ` Dmitry Baryshkov
2022-11-14 15:38 ` Johan Hovold
2022-11-14 16:14 ` Dmitry Baryshkov
2022-11-14 16:42 ` Johan Hovold
2022-11-14 16:51 ` Dmitry Baryshkov
2022-11-14 16:53 ` Johan Hovold
2022-11-14 15:49 ` Krzysztof Kozlowski
2022-11-14 16:32 ` Johan Hovold
2022-11-14 16:39 ` Krzysztof Kozlowski
2022-11-14 16:48 ` Johan Hovold
2022-11-14 16:56 ` Krzysztof Kozlowski
2022-11-14 17:08 ` Johan Hovold
2022-11-15 8:12 ` Krzysztof Kozlowski
2022-11-15 14:22 ` Johan Hovold
2022-11-15 14:56 ` Krzysztof Kozlowski
2022-11-12 11:43 ` Dmitry Baryshkov
2022-11-14 13:37 ` Johan Hovold
2022-11-14 15:31 ` Dmitry Baryshkov
2022-11-14 16:21 ` Johan Hovold
2022-11-11 9:24 ` [PATCH 03/14] phy: qcom-qmp-combo: drop v4 reference-clock source Johan Hovold
2022-11-12 11:43 ` Dmitry Baryshkov [this message]
2022-11-14 13:03 ` Johan Hovold
2022-11-11 9:24 ` [PATCH 04/14] phy: qcom-qmp-combo: restructure PHY creation Johan Hovold
2022-11-11 9:28 ` Johan Hovold
2022-11-11 15:18 ` Krzysztof Kozlowski
2022-11-11 15:19 ` Krzysztof Kozlowski
2022-11-11 9:24 ` [PATCH 05/14] phy: qcom-qmp-combo: register clocks sooner Johan Hovold
2022-11-12 11:15 ` Dmitry Baryshkov
2022-11-14 13:42 ` Johan Hovold
2022-11-11 9:24 ` [PATCH 06/14] phy: qcom-qmp-combo: generate pipe clock name Johan Hovold
2022-11-12 11:15 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 07/14] phy: qcom-qmp-combo: drop redundant clock structure Johan Hovold
2022-11-12 11:16 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 08/14] phy: qcom-qmp-combo: drop redundant clock allocation Johan Hovold
2022-11-12 11:17 ` Dmitry Baryshkov
2022-11-14 12:42 ` Johan Hovold
2022-11-14 15:31 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 09/14] phy: qcom-qmp-combo: add clock registration helper Johan Hovold
2022-11-14 10:12 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 10/14] phy: qcom-qmp-combo: separate clock and provider registration Johan Hovold
2022-11-14 10:13 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 11/14] phy: qcom-qmp-combo: clean up DP clock callbacks Johan Hovold
2022-11-12 11:20 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 12/14] phy: qcom-qmp-combo: rename common-register pointers Johan Hovold
2022-11-12 11:31 ` Dmitry Baryshkov
2022-11-14 12:54 ` Johan Hovold
2022-11-14 15:38 ` Dmitry Baryshkov
2022-11-14 15:51 ` Johan Hovold
2022-11-11 9:24 ` [PATCH 13/14] phy: qcom-qmp-combo: rename DP_PHY register pointer Johan Hovold
2022-11-12 11:31 ` Dmitry Baryshkov
2022-11-11 9:24 ` [PATCH 14/14] phy: qcom-qmp-combo: add support for updated sc8280xp binding Johan Hovold
2022-11-12 11:36 ` Dmitry Baryshkov
2022-11-14 12:58 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14f01c33-dada-b66a-f81a-74b9028de18b@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).