linux-phy.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode for J784S4
@ 2023-12-21 10:29 Chintan Vankar
  2023-12-21 10:29 ` [RFC PATCH 2/2] phy: ti: j721e-wiz: Add SGMII support in WIZ driver " Chintan Vankar
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Chintan Vankar @ 2023-12-21 10:29 UTC (permalink / raw)
  To: Maxime Ripard, Uwe Kleine-König, Sinthu Raja, Chintan Vankar,
	Andrew Davis, Siddharth Vadapalli, Roger Quadros,
	Kishon Vijay Abraham I, Vinod Koul
  Cc: linux-kernel, linux-phy

TI's J784S4 SoC supports SGMII mode with the CPSW9G instance of the CPSW
Ethernet Switch. Thus, enable it by adding SGMII mode to the list of the
corresponding extra_modes member.

Signed-off-by: Chintan Vankar <c-vankar@ti.com>
---
 drivers/phy/ti/phy-gmii-sel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c
index bc847d3879f7..0f4818adb440 100644
--- a/drivers/phy/ti/phy-gmii-sel.c
+++ b/drivers/phy/ti/phy-gmii-sel.c
@@ -248,7 +248,7 @@ static const
 struct phy_gmii_sel_soc_data phy_gmii_sel_cpsw9g_soc_j784s4 = {
 	.use_of_data = true,
 	.regfields = phy_gmii_sel_fields_am654,
-	.extra_modes = BIT(PHY_INTERFACE_MODE_QSGMII) |
+	.extra_modes = BIT(PHY_INTERFACE_MODE_QSGMII) | BIT(PHY_INTERFACE_MODE_SGMII) |
 		       BIT(PHY_INTERFACE_MODE_USXGMII),
 	.num_ports = 8,
 	.num_qsgmii_main_ports = 2,
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [RFC PATCH 2/2] phy: ti: j721e-wiz: Add SGMII support in WIZ driver for J784S4
  2023-12-21 10:29 [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode for J784S4 Chintan Vankar
@ 2023-12-21 10:29 ` Chintan Vankar
  2023-12-22 10:13   ` Roger Quadros
  2023-12-22 10:12 ` [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode " Roger Quadros
  2023-12-22 15:50 ` Vinod Koul
  2 siblings, 1 reply; 5+ messages in thread
From: Chintan Vankar @ 2023-12-21 10:29 UTC (permalink / raw)
  To: Maxime Ripard, Uwe Kleine-König, Sinthu Raja, Chintan Vankar,
	Andrew Davis, Siddharth Vadapalli, Roger Quadros,
	Kishon Vijay Abraham I, Vinod Koul
  Cc: linux-kernel, linux-phy

Enable full rate divider configuration support for J784S4_WIZ_10G
for SGMII.

Signed-off-by: Chintan Vankar <c-vankar@ti.com>
---
 drivers/phy/ti/phy-j721e-wiz.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index fc3cd98c60ff..00d7e6a6de03 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -1240,6 +1240,7 @@ static int wiz_phy_fullrt_div(struct wiz *wiz, int lane)
 	case J721E_WIZ_10G:
 	case J7200_WIZ_10G:
 	case J721S2_WIZ_10G:
+	case J784S4_WIZ_10G:
 		if (wiz->lane_phy_type[lane] == PHY_TYPE_SGMII)
 			return regmap_field_write(wiz->p0_fullrt_div[lane], 0x2);
 		break;
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode for J784S4
  2023-12-21 10:29 [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode for J784S4 Chintan Vankar
  2023-12-21 10:29 ` [RFC PATCH 2/2] phy: ti: j721e-wiz: Add SGMII support in WIZ driver " Chintan Vankar
@ 2023-12-22 10:12 ` Roger Quadros
  2023-12-22 15:50 ` Vinod Koul
  2 siblings, 0 replies; 5+ messages in thread
From: Roger Quadros @ 2023-12-22 10:12 UTC (permalink / raw)
  To: Chintan Vankar, Maxime Ripard, Uwe Kleine-König, Sinthu Raja,
	Andrew Davis, Siddharth Vadapalli, Kishon Vijay Abraham I,
	Vinod Koul
  Cc: linux-kernel, linux-phy



On 21/12/2023 12:29, Chintan Vankar wrote:
> TI's J784S4 SoC supports SGMII mode with the CPSW9G instance of the CPSW
> Ethernet Switch. Thus, enable it by adding SGMII mode to the list of the
> corresponding extra_modes member.
> 
> Signed-off-by: Chintan Vankar <c-vankar@ti.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

-- 
cheers,
-roger

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC PATCH 2/2] phy: ti: j721e-wiz: Add SGMII support in WIZ driver for J784S4
  2023-12-21 10:29 ` [RFC PATCH 2/2] phy: ti: j721e-wiz: Add SGMII support in WIZ driver " Chintan Vankar
@ 2023-12-22 10:13   ` Roger Quadros
  0 siblings, 0 replies; 5+ messages in thread
From: Roger Quadros @ 2023-12-22 10:13 UTC (permalink / raw)
  To: Chintan Vankar, Maxime Ripard, Uwe Kleine-König, Sinthu Raja,
	Andrew Davis, Siddharth Vadapalli, Kishon Vijay Abraham I,
	Vinod Koul
  Cc: linux-kernel, linux-phy



On 21/12/2023 12:29, Chintan Vankar wrote:
> Enable full rate divider configuration support for J784S4_WIZ_10G
> for SGMII.
> 
> Signed-off-by: Chintan Vankar <c-vankar@ti.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

-- 
cheers,
-roger

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode for J784S4
  2023-12-21 10:29 [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode for J784S4 Chintan Vankar
  2023-12-21 10:29 ` [RFC PATCH 2/2] phy: ti: j721e-wiz: Add SGMII support in WIZ driver " Chintan Vankar
  2023-12-22 10:12 ` [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode " Roger Quadros
@ 2023-12-22 15:50 ` Vinod Koul
  2 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2023-12-22 15:50 UTC (permalink / raw)
  To: Maxime Ripard, Uwe Kleine-König, Sinthu Raja, Andrew Davis,
	Siddharth Vadapalli, Roger Quadros, Kishon Vijay Abraham I,
	Chintan Vankar
  Cc: linux-kernel, linux-phy


On Thu, 21 Dec 2023 15:59:55 +0530, Chintan Vankar wrote:
> TI's J784S4 SoC supports SGMII mode with the CPSW9G instance of the CPSW
> Ethernet Switch. Thus, enable it by adding SGMII mode to the list of the
> corresponding extra_modes member.
> 
> 

Applied, thanks!

[1/2] phy: ti: gmii-sel: Enable SGMII mode for J784S4
      commit: d719915ad9706a16adde231789a1d46fc12fb9c7
[2/2] phy: ti: j721e-wiz: Add SGMII support in WIZ driver for J784S4
      commit: 2029e71482fcd94dcc7df2c66c7fa635479748bf

Best regards,
-- 
~Vinod



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-12-22 15:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-21 10:29 [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode for J784S4 Chintan Vankar
2023-12-21 10:29 ` [RFC PATCH 2/2] phy: ti: j721e-wiz: Add SGMII support in WIZ driver " Chintan Vankar
2023-12-22 10:13   ` Roger Quadros
2023-12-22 10:12 ` [RFC PATCH 1/2] phy: ti: gmii-sel: Enable SGMII mode " Roger Quadros
2023-12-22 15:50 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).