From: Rob Herring <robh@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
linux-phy@lists.infradead.org, linux-arm-msm@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
devicetree@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
vkoul@kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v4 1/8] dt-bindings: phy: Add qcom,snps-eusb2-phy schema file
Date: Thu, 02 Feb 2023 09:03:31 -0600 [thread overview]
Message-ID: <167535003746.1854137.3170990536949157461.robh@kernel.org> (raw)
In-Reply-To: <20230202132511.3983095-2-abel.vesa@linaro.org>
On Thu, 02 Feb 2023 15:25:04 +0200, Abel Vesa wrote:
> The SM8550 SoC uses Synopsis eUSB2 PHY. Add a dt-binding schema
> for the new driver.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> The v3 version of this patch was here:
> https://lore.kernel.org/all/20230126131415.1453741-2-abel.vesa@linaro.org/
>
> Changes since v3:
> * removed blank line, like Rob suggested
> * dropped quotes and reset description, like Rob suggested
> * dropped the RPMH_CXO_PAD_CLK clock and the ref_src clock name
> to match the schema
> * fixed filenames of the includes in the example (sm8550-gcc and
> sm8550-tcsr)
>
> Changes since v2:
> * none
>
> Changes since v1:
> * dropped the "ref src" clock
> * dropped the usb-repeater property
>
> .../bindings/phy/qcom,snps-eusb2-phy.yaml | 74 +++++++++++++++++++
> 1 file changed, 74 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.example.dts:20:18: fatal error: dt-bindings/clock/qcom,sm8550-tcsr.h: No such file or directory
20 | #include <dt-bindings/clock/qcom,sm8550-tcsr.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1508: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230202132511.3983095-2-abel.vesa@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-02-02 15:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 13:25 [PATCH v4 0/8] sm8550: Add USB HC and PHYs support Abel Vesa
2023-02-02 13:25 ` [PATCH v4 1/8] dt-bindings: phy: Add qcom,snps-eusb2-phy schema file Abel Vesa
2023-02-02 15:03 ` Rob Herring [this message]
2023-02-02 13:25 ` [PATCH v4 2/8] phy: qcom: Add QCOM SNPS eUSB2 driver Abel Vesa
2023-02-02 13:25 ` [PATCH v4 3/8] dt-bindings: phy: qcom,qmp-usb: Document SM8550 compatible Abel Vesa
2023-02-03 10:37 ` Johan Hovold
2023-02-02 13:25 ` [PATCH v4 4/8] phy: qcom-qmp: pcs-usb: Add v6 register offsets Abel Vesa
2023-02-02 13:25 ` [PATCH v4 5/8] phy: qcom-qmp: Add v6 DP " Abel Vesa
2023-02-02 13:25 ` [PATCH v4 6/8] phy: qcom-qmp-combo: Add support for SM8550 Abel Vesa
2023-02-03 10:52 ` Johan Hovold
2023-02-02 13:25 ` [PATCH v4 7/8] arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes Abel Vesa
2023-02-03 10:55 ` Johan Hovold
2023-02-07 11:03 ` Abel Vesa
2023-02-07 11:16 ` Johan Hovold
2023-02-02 13:25 ` [PATCH v4 8/8] arm64: dts: qcom: sm8550-mtp: Add USB PHYs and HC nodes Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167535003746.1854137.3170990536949157461.robh@kernel.org \
--to=robh@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox