From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D3F3C10F09 for ; Wed, 6 Dec 2023 03:40:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Subject:Message-Id:References: In-Reply-To:Cc:To:From:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6ZnRtld03lG8do5J7XksKq6rHBRn8New2y+tUgP1lkQ=; b=JHKV/FXmCWbFBp WaQ+mB7W8qhxzhLjXT/OJizoQEZGtrikqdADPulh1LUfnydlYAeSNwYBZKM853P7KZVuP4rzOmy7Y c7K2K6Zdaza0HeWRi+I0n+KMTtlgoqRhn9+mDEByKwa6pKB+I60BD4zw/z1gNjfOJEbolAFVZzlno +nm811Z5yf+y7YJNjml1FG2wDPRa5dxJ17nR+WemWAnbjYs7z8u23x8TQEIb+trN3SMu6qpkbpY1w nGgro9if94ZNsintdvm+NKu9eYHR7nIikT5q6Z/IbhkZIOIU/jF9DKLtReI1wg30RGYJxmTiNrmVS WAbL6CC/P8fALABaCPdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAilX-008yim-0P; Wed, 06 Dec 2023 03:40:03 +0000 Received: from mail-oa1-f51.google.com ([209.85.160.51]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAilR-008ycP-1B; Wed, 06 Dec 2023 03:39:58 +0000 Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-1fa26074783so3460075fac.1; Tue, 05 Dec 2023 19:39:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701833996; x=1702438796; h=date:subject:message-id:references:in-reply-to:cc:to:from :mime-version:content-transfer-encoding:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hLT1BoNdZOsa14xuLGA+JXdO1aXqfEnpbPJsybdwp2I=; b=xOdmBLhYqZOSNAC2slxfEKAww7B0Gc47HHDQwdpYAbaNy1zhkyeLtw1MzCRft6cvB6 5E90uFYepsypcHhX2hre/YZ7x5OVspUSXgmzZ8GQVmHHbyLpT1gLsPkCycpZC8yCtgQW NtRcg2O4oScE5ww8Re+o+oVYb+ocyzUFaZQO0D+vzirhe3F0ajE+GW4H0aa1aVeP2V6r 6VLqloBWNv0w0HlrhiR/HBgLl7+OYilnWYqO0XWsKKRjipZNeSjOfrG4toCUMXIzj4AS y4mrHCsA/j7jTNCHt9RJR7iuCKFdj1OOYw4PqombgV5LDnoA6OU8r1izDJeMijnvHJse hqRg== X-Gm-Message-State: AOJu0YzXcQHJeIYJlcHGcUGW1k9EUcwEHLAc92W8Xkd6IcqLMIxNhr3J JEFzU0GxI3r1Ch5XX7k3iA== X-Google-Smtp-Source: AGHT+IGTmq+FN6dwgEMD4lsPZ+v8n15aufTQBAy0f7TbjXAqsv/BoIE1ZkwoUbLlWPs6l+CoQNYQTg== X-Received: by 2002:a05:6870:9690:b0:1fb:75a:de65 with SMTP id o16-20020a056870969000b001fb075ade65mr268467oaq.83.1701833996268; Tue, 05 Dec 2023 19:39:56 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id pk28-20020a0568704c1c00b001fafc32e808sm2929937oab.0.2023.12.05.19.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 19:39:55 -0800 (PST) Received: (nullmailer pid 463141 invoked by uid 1000); Wed, 06 Dec 2023 03:39:36 -0000 MIME-Version: 1.0 From: Rob Herring To: Daniel Golle Cc: linux-kernel@vger.kernel.org, Vinod Koul , Kishon Vijay Abraham I , Sean Wang , Philipp Zabel , Chunfeng Yun , Heiner Kallweit , Russell King , AngeloGioacchino Del Regno , Matthias Brugger , SkyLake Huang , devicetree@vger.kernel.org, Paolo Abeni , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , John Crispin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, Conor Dooley , Felix Fietkau , "David S. Miller" , Andrew Lunn , linux-mediatek@lists.infradead.org, Rob Herring , Mark Lee , Lorenzo Bianconi , Alexander Couzens , Qingfang Deng In-Reply-To: References: Message-Id: <170183397527.463082.3332126649962865060.robh@kernel.org> Subject: Re: [RFC PATCH v2 6/8] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes Date: Tue, 05 Dec 2023 21:39:36 -0600 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231205_193957_416639_E693C5C2 X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Wed, 06 Dec 2023 01:44:51 +0000, Daniel Golle wrote: > Several clocks as well as both sgmiisys phandles were added by mistake > to the Ethernet bindings for MT7988. > > This happened because the vendor driver which served as a reference > uses a high number of syscon phandles to access various parts of the > SoC which wasn't acceptable upstream. Hence several parts which have > never previously been supported (such SerDes PHY and USXGMII PCS) have > been moved to separate drivers which also result in a much more sane > device tree. > > Quickly align the bindings with the upcoming reality of the drivers > actually adding full support for this SoC. > > Fixes: c94a9aabec36 ("dt-bindings: net: mediatek,net: add mt7988-eth binding") > Signed-off-by: Daniel Golle > --- > .../devicetree/bindings/net/mediatek,net.yaml | 32 ++++--------------- > 1 file changed, 7 insertions(+), 25 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/net/pcs/mediatek,usxgmii.example.dts:18:18: fatal error: dt-bindings/clock/mediatek,mt7988-clk.h: No such file or directory make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/net/pcs/mediatek,usxgmii.example.dtb] Error 1 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/e2214e904cde9a9d64ec1e87ac38560f7ac35a1f.1701826319.git.daniel@makrotopia.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy