From: Vinod Koul <vkoul@kernel.org>
To: linux-phy@lists.infradead.org, Marcel Ziswiler <marcel@ziswiler.com>
Cc: linux-imx@nxp.com, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, Richard Zhu <hongxing.zhu@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Tim Harvey <tharvey@gateworks.com>,
Yang Li <yang.lee@linux.alibaba.com>,
imx@lists.linux.dev
Subject: Re: [PATCH v2] phy: freescale: imx8m-pcie: fix pcie link-up instability
Date: Sat, 06 Apr 2024 14:48:44 +0530 [thread overview]
Message-ID: <171239512402.352254.17030670986383011631.b4-ty@kernel.org> (raw)
In-Reply-To: <20240327071946.8869-1-marcel@ziswiler.com>
On Wed, 27 Mar 2024 08:19:37 +0100, Marcel Ziswiler wrote:
> On the i.MX 8M Mini, the AUX_PLL_REFCLK_SEL has to be left at its reset
> default of AUX_IN (PLL clock).
>
> Background Information:
> In our automated testing setup, we use Delock Mini-PCIe SATA cards [1].
> While this setup has proven very stable overall we noticed upstream on
> the i.MX 8M Mini fails quite regularly (about 50/50) to bring up the
> PCIe link while with NXP's downstream BSP 5.15.71_2.2.2 it always works.
> As that old downstream stuff was quite different, I first also tried
> NXP's latest downstream BSP 6.1.55_2.2.0 which from a PCIe point of view
> is fairly vanilla, however, also there the PCIe link-up was not stable.
> Comparing and debugging I noticed that upstream explicitly configures
> the AUX_PLL_REFCLK_SEL to I_PLL_REFCLK_FROM_SYSPLL while working
> downstream [2] leaving it at reset defaults of AUX_IN (PLL clock).
> Unfortunately, the TRM does not mention any further details about this
> register (both for the i.MX 8M Mini as well as the Plus).
> NXP confirmed their validation codes for the i.MX8MM PCIe doesn't
> configure cmn_reg063 (offset: 0x18C).
> BTW: On the i.MX 8M Plus we have not seen any issues with PCIe with the
> exact same setup which is why I left it unchanged.
>
> [...]
Applied, thanks!
[1/1] phy: freescale: imx8m-pcie: fix pcie link-up instability
commit: 3a161017f1de55cc48be81f6156004c151f32677
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-04-06 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 7:19 [PATCH v2] phy: freescale: imx8m-pcie: fix pcie link-up instability Marcel Ziswiler
2024-04-06 7:18 ` Vinod Koul
2024-04-06 9:18 ` Vinod Koul [this message]
2024-04-07 22:23 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171239512402.352254.17030670986383011631.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sergio.paracuellos@gmail.com \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox