From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8FB0C83F1A for ; Mon, 21 Jul 2025 16:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:References: In-Reply-To:To:Cc:From:MIME-Version:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=tm2CbPHPkS3HLc2rqTI5o72vYkOek5S981MPDVuxT+M=; b=sa0MXYFij+Un6+SuX4WtVK8gGM pT+/2+19QPz6h0ZPtT6z8q1nIUoHWEQA0grnxH5+qFwNbpcABw86tySGaWclqbaq/qxUCpgPUum89 n5+OeM8hqVmBXxKkWC72++pVsqxuqyjCNnSzvbsZ2oBOV+KfbVGT6TQNs1KTVgwVjIoQkLmERhYDR C53JS5NwSGlqSQMXCjsPV1tpeIyJmq4zqQyeRAznQD5UcHD3iybJvzDm0J264l3LRqCVA+LGgywps VHTu9pvimMO7aEq0L7D6HNeBpU/OBxm/uRoAfWbKm2y+KfymOEgLzQg8lkp462w/GtNqS8ggUm4gA i3ikAPkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1udtbB-00000000Byw-1i6g; Mon, 21 Jul 2025 16:42:45 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1udrPe-0000000HVTZ-3jPf for linux-phy@lists.infradead.org; Mon, 21 Jul 2025 14:22:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id DFE5D61360; Mon, 21 Jul 2025 14:22:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ED11C4CEED; Mon, 21 Jul 2025 14:22:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753107761; bh=hjlOeyxnWBA0TOKevAsG8is1xc1FHdQAJGdi4sv+25E=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=fCPLqNbk4Np3CnxgYlMcSjlwKA8svRsnfJNRoC4iuS5dWBr1Y2vz1VzwdiIa7oIRa AQKz+iYI7ERtgAC5sCquPQlu//5IKGu+UGUhg4WPE2tC2UwFo3VGWyKJHbKvusSR2B 8RxcD7kdb2ufVVCa9KYGKaYWELY2AyMVk2HNk4RYO0fSLa2oy7PtuB3M87X4M8Z6x5 cqmo37jgd3CxzOw+dZkFXQsSyruW4B0DfU+KzbvbwxWppZWNw0VPbLLeL3kJ/ZZ/9y q5U2unWXn3zw0cLYafQ/Nqc3AVhxvnSRIb9mVwkarwrcUnlcusUtj6rAeipq8m3s5Q F4xR+XYNhgQWA== Date: Mon, 21 Jul 2025 09:22:40 -0500 MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: Azkali Manad , Zhang Rui , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, JC Kuo , Conor Dooley , Jonathan Hunter , Prashant Gaikwad , Stephen Boyd , Nagarjuna Kristam , Kishon Vijay Abraham I , "Rafael J. Wysocki" , Greg Kroah-Hartman , Daniel Lezcano , Michael Turquette , Peter De Schrijver , linux-phy@lists.infradead.org, Krzysztof Kozlowski , Thierry Reding , Thierry Reding , Lukasz Luba , linux-pm@vger.kernel.org, Mathias Nyman , Vinod Koul , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Aaron Kling In-Reply-To: <20250720-t210b01-v2-0-9cb209f1edfc@gmail.com> References: <20250720-t210b01-v2-0-9cb209f1edfc@gmail.com> Message-Id: <175310755862.577282.10932067975211977362.robh@kernel.org> Subject: Re: [PATCH v2 00/17] arm64: tegra: Add Tegra210B01 support X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Sun, 20 Jul 2025 21:14:54 -0500, Aaron Kling wrote: > Also known as Tegra X1+, the Tegra210B01 has higher CPU and GPU clocks > than the original Tegra210. > > This series adds Tegra210B01 support to several drivers, as a slight > extension to the existing Tegra210 support. Then adds a generic soc dtsi > in the same vein as other tegra archs. And finally adds a barebones > device dts to be used for dt checks. Further device support will be > submitted in later series. > > Earlier internal revisions of this series included changes to the dfll > driver to support Tegra210B01, but those did not work in testing, thus > was dropped from the series. A bindings update to match is still in the > series so the soc dtsi can declare a separate compatible from Tegra210, > preventing the driver from attempting incorrect initialization on > Tegra210B01. > > Signed-off-by: Aaron Kling > --- > Changes in v2: > - Fix patch 1 subject > - Add descriptive name in patch 8 > - Fix copy-paste error in patch 13, discovered by kernel ci > - Link to v1: https://lore.kernel.org/r/20250714-t210b01-v1-0-e3f5f7de5dce@gmail.com > > --- > Aaron Kling (16): > dt-bindings: soc: tegra: pmc: Document Tegra210B01 > dt-bindings: phy: tegra-xusb: Document Tegra210B01 > dt-bindings: usb: tegra-xusb: Document Tegra210B01 > dt-bindings: usb: tegra-xudc: Document Tegra210B01 > dt-bindings: thermal: tegra: Document Tegra210B01 > dt-bindings: clock: tegra: Document Tegra210B01 > dt-bindings: clock: tegra124-dfll: Document Tegra210B01 > dt-bindings: tegra: Document Shield TV 2019 > phy: tegra: xusb: Add Tegra201B01 Support > usb: xhci: tegra: Add Tegra210B01 support > usb: gadget: tegra-xudc: Add Tegra210B01 Support > thermal: tegra: Add Tegra210B01 Support > clk: tegra: Add Tegra210B01 support > arm64: tegra: Add BPMP node for Tegra210 > arm64: tegra: Add Tegra210B01 support > arm64: tegra: Add support for NVIDIA Shield TV Pro 2019 > > Azkali Manad (1): > soc/tegra: pmc: Add Tegra210B01 support > > Documentation/devicetree/bindings/arm/tegra.yaml | 6 + > .../bindings/clock/nvidia,tegra124-dfll.txt | 1 + > .../bindings/clock/nvidia,tegra20-car.yaml | 1 + > .../bindings/phy/nvidia,tegra210-xusb-padctl.yaml | 4 +- > .../bindings/soc/tegra/nvidia,tegra20-pmc.yaml | 5 +- > .../bindings/thermal/nvidia,tegra124-soctherm.yaml | 2 + > .../devicetree/bindings/usb/nvidia,tegra-xudc.yaml | 2 + > .../bindings/usb/nvidia,tegra210-xusb.yaml | 4 +- > arch/arm64/boot/dts/nvidia/Makefile | 1 + > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 11 + > .../boot/dts/nvidia/tegra210b01-p2894-0050-a08.dts | 10 + > arch/arm64/boot/dts/nvidia/tegra210b01-p2894.dtsi | 70 + > arch/arm64/boot/dts/nvidia/tegra210b01.dtsi | 64 + > drivers/clk/tegra/Makefile | 1 + > drivers/clk/tegra/clk-tegra-periph.c | 3 + > drivers/clk/tegra/clk-tegra210b01.c | 3758 ++++++++++++++++++++ > drivers/clk/tegra/clk-utils.c | 5 +- > drivers/clk/tegra/clk.c | 19 +- > drivers/clk/tegra/clk.h | 6 + > drivers/phy/tegra/xusb-tegra210.c | 41 + > drivers/phy/tegra/xusb.c | 4 + > drivers/phy/tegra/xusb.h | 1 + > drivers/soc/tegra/pmc.c | 117 + > drivers/thermal/tegra/soctherm.c | 4 + > drivers/thermal/tegra/soctherm.h | 1 + > drivers/thermal/tegra/tegra210-soctherm.c | 78 + > drivers/usb/gadget/udc/tegra-xudc.c | 20 + > drivers/usb/host/xhci-tegra.c | 25 + > include/dt-bindings/clock/tegra210-car.h | 5 +- > 29 files changed, 4262 insertions(+), 7 deletions(-) > --- > base-commit: 347e9f5043c89695b01e66b3ed111755afcf1911 > change-id: 20250509-t210b01-c154ca0f8994 > > Best regards, > -- > Aaron Kling > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade This patch series was applied (using b4) to base: Base: using specified base-commit 347e9f5043c89695b01e66b3ed111755afcf1911 If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically) New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250720-t210b01-v2-0-9cb209f1edfc@gmail.com: arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /pcie@1003000: failed to match any schema with compatible: ['nvidia,tegra210-pcie'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /host1x@50000000/tsec@54100000: failed to match any schema with compatible: ['nvidia,tegra210-tsec'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /host1x@50000000/tsec@54500000: failed to match any schema with compatible: ['nvidia,tegra210-tsec'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /gpu@57000000: failed to match any schema with compatible: ['nvidia,gm20b'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /interrupt-controller@60004000: failed to match any schema with compatible: ['nvidia,tegra210-ictlr'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /dma@60020000: failed to match any schema with compatible: ['nvidia,tegra210-apbdma', 'nvidia,tegra148-apbdma'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /dma@60020000: failed to match any schema with compatible: ['nvidia,tegra210-apbdma', 'nvidia,tegra148-apbdma'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /memory-controller@70019000: failed to match any schema with compatible: ['nvidia,tegra210-mc'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: external-memory-controller@7001b000 (nvidia,tegra210-emc): '#cooling-cells' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/memory-controllers/nvidia,tegra210-emc.yaml# arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /clock@70110000: failed to match any schema with compatible: ['nvidia,tegra210b01-dfll'] arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: usb-phy@7d000000 (nvidia,tegra210-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed: ['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy'] is too long 'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra124-usb-phy', 'nvidia,tegra114-usb-phy'] 'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra30-usb-phy', 'nvidia,tegra20-usb-phy'] from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra20-usb-phy.yaml# arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /usb-phy@7d000000: failed to match any schema with compatible: ['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: usb-phy@7d004000 (nvidia,tegra210-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed: ['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy'] is too long 'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra124-usb-phy', 'nvidia,tegra114-usb-phy'] 'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra30-usb-phy', 'nvidia,tegra20-usb-phy'] from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra20-usb-phy.yaml# arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: /usb-phy@7d004000: failed to match any schema with compatible: ['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy'] arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: cpu@0 (arm,cortex-a57): 'operating-points' is a dependency of 'clock-latency' from schema $id: http://devicetree.org/schemas/arm/cpus.yaml# arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: cpu@0 (arm,cortex-a57): Unevaluated properties are not allowed ('clock-latency' was unexpected) from schema $id: http://devicetree.org/schemas/arm/cpus.yaml# arch/arm64/boot/dts/nvidia/tegra210b01-p2894-0050-a08.dtb: thermal-zones: mem-thermal:cooling-maps: 'dram-active', 'dram-passive' do not match any of the regexes: '^map[-a-zA-Z0-9]*$', '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml# arch/arm64/boot/dts/nvidia/tegra210-p2371-0000.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp'] arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp'] arch/arm64/boot/dts/nvidia/tegra210-p2571.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp'] arch/arm64/boot/dts/nvidia/tegra210-smaug.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp'] arch/arm64/boot/dts/nvidia/tegra210-p2894-0050-a08.dtb: /bpmp@70016000: failed to match any schema with compatible: ['nvidia,tegra210-bpmp'] -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy