From: Vinod Koul <vkoul@kernel.org>
To: linux-phy@lists.infradead.org,
Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH phy-fixes] phy: lynx-28g: skip CDR lock workaround for lanes disabled in the device tree
Date: Fri, 27 Feb 2026 20:55:10 +0530 [thread overview]
Message-ID: <177220591001.320398.14824622688771745554.b4-ty@kernel.org> (raw)
In-Reply-To: <20260226182853.1103616-1-vladimir.oltean@nxp.com>
On Thu, 26 Feb 2026 20:28:53 +0200, Vladimir Oltean wrote:
> The blamed commit introduced support for specifying individual lanes as
> OF nodes in the device, and these can have status = "disabled".
>
> When that happens, for_each_available_child_of_node() skips them and
> lynx_28g_probe_lane() -> devm_phy_create() is not called, so lane->phy
> will be NULL. Yet it will be dereferenced in lynx_28g_cdr_lock_check(),
> resulting in a crash.
>
> [...]
Applied, thanks!
[1/1] phy: lynx-28g: skip CDR lock workaround for lanes disabled in the device tree
commit: a258d843a3e4cb687da19437f8f81fee55ad7d35
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2026-02-27 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 18:28 [PATCH phy-fixes] phy: lynx-28g: skip CDR lock workaround for lanes disabled in the device tree Vladimir Oltean
2026-02-27 15:25 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177220591001.320398.14824622688771745554.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox