From: Vinod Koul <vkoul@kernel.org>
To: neil.armstrong@linaro.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
Yulin Lu <luyulin@eswincomputing.com>
Cc: linmin@eswincomputing.com, ningyu@eswincomputing.com,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v1] phy: eswin: Fix incorrect error check in probe()
Date: Sun, 10 May 2026 17:53:58 +0530 [thread overview]
Message-ID: <177841583822.420676.10517749667469698139.b4-ty@kernel.org> (raw)
In-Reply-To: <20260413070033.128-1-luyulin@eswincomputing.com>
On Mon, 13 Apr 2026 15:00:33 +0800, Yulin Lu wrote:
> devm_ioremap() returns NULL on failure, not an ERR_PTR.
> Using IS_ERR() to check the return value is incorrect.
>
> Fix this by checking for NULL and returning -ENOMEM.
>
>
Applied, thanks!
[1/1] phy: eswin: Fix incorrect error check in probe()
commit: c2cd08e8f150738515c8df415ad7ecfa3d38124a
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2026-05-10 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 7:00 [PATCH v1] phy: eswin: Fix incorrect error check in probe() Yulin Lu
2026-05-10 12:23 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177841583822.420676.10517749667469698139.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=error27@gmail.com \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=luyulin@eswincomputing.com \
--cc=neil.armstrong@linaro.org \
--cc=ningyu@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox