From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Peter Wang (王信友)" <peter.wang@mediatek.com>,
"chu.stanley@gmail.com" <chu.stanley@gmail.com>,
"robh@kernel.org" <robh@kernel.org>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"kishon@kernel.org" <kishon@kernel.org>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"Chaotian Jing (井朝天)" <Chaotian.Jing@mediatek.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"nicolas.frattaroli@collabora.com"
<nicolas.frattaroli@collabora.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"broonie@kernel.org" <broonie@kernel.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: [PATCH v4 11/25] scsi: ufs: mediatek: Rework probe function
Date: Thu, 8 Jan 2026 13:19:10 +0100 [thread overview]
Message-ID: <1e365223-8e20-4519-b290-d8ecff548d84@kernel.org> (raw)
In-Reply-To: <213d3077835fc86d15579c0a0a91f64fd84b1059.camel@mediatek.com>
On 06/01/2026 14:23, Peter Wang (王信友) wrote:
> On Thu, 2025-12-18 at 13:55 +0100, Nicolas Frattaroli wrote:
>>
>> Remove the ti,syscon-reset cruft.
>>
>
> Hi Nicolas,
>
> Why do we need to remove the reset node? If an error occurs and the
Commit msg should be improved and provide the reason, e.g. because it is
undocumented and unused ABI.
> host
> does not perform a reset, it could lead to error recovery failure.
This is not a reason to use undocumented ABI.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-01-08 12:19 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 12:54 [PATCH v4 00/25] MediaTek UFS Cleanup and MT8196 Enablement Nicolas Frattaroli
2025-12-18 12:54 ` [PATCH v4 01/25] dt-bindings: phy: Add mediatek,mt8196-ufsphy variant Nicolas Frattaroli
2025-12-18 19:25 ` Conor Dooley
2025-12-23 17:39 ` Vinod Koul
2025-12-18 12:54 ` [PATCH v4 02/25] dt-bindings: ufs: mediatek,ufs: Complete the binding Nicolas Frattaroli
2025-12-18 19:38 ` Conor Dooley
2025-12-23 17:39 ` Vinod Koul
[not found] ` <e30abc4cbda3d655d9e0ef2beeac1456b93febb5.camel@mediatek.com>
2026-01-05 8:00 ` Nicolas Frattaroli
2025-12-18 12:54 ` [PATCH v4 03/25] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant Nicolas Frattaroli
2025-12-18 19:26 ` Conor Dooley
2025-12-23 17:39 ` Vinod Koul
2025-12-18 12:54 ` [PATCH v4 04/25] scsi: ufs: mediatek: Move MTK_SIP_UFS_CONTROL to mtk_sip_svc.h Nicolas Frattaroli
2025-12-18 12:54 ` [PATCH v4 05/25] phy: mediatek: ufs: Add support for resets Nicolas Frattaroli
2025-12-23 17:39 ` Vinod Koul
2025-12-18 12:54 ` [PATCH v4 06/25] scsi: ufs: mediatek: Rework resets Nicolas Frattaroli
2025-12-18 12:54 ` [PATCH v4 07/25] scsi: ufs: mediatek: Rework 0.9V regulator Nicolas Frattaroli
[not found] ` <8206d9e715f7ef987b5369d0bda68cce13528112.camel@mediatek.com>
2025-12-23 16:13 ` Nicolas Frattaroli
2025-12-18 12:54 ` [PATCH v4 08/25] scsi: ufs: mediatek: Rework init function Nicolas Frattaroli
2025-12-18 12:54 ` [PATCH v4 09/25] scsi: ufs: mediatek: Rework the crypt-boost stuff Nicolas Frattaroli
[not found] ` <a12f7ffe8448d205a7318219ea7a18f0f722727f.camel@mediatek.com>
2026-01-05 8:05 ` Nicolas Frattaroli
2026-01-06 13:22 ` Peter Wang (王信友)
2025-12-18 12:55 ` [PATCH v4 10/25] scsi: ufs: mediatek: Handle misc host voltage regulators Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 11/25] scsi: ufs: mediatek: Rework probe function Nicolas Frattaroli
2026-01-06 13:23 ` Peter Wang (王信友)
2026-01-08 9:14 ` Nicolas Frattaroli
2026-01-09 6:18 ` Peter Wang (王信友)
2026-01-08 12:19 ` Krzysztof Kozlowski [this message]
2025-12-18 12:55 ` [PATCH v4 12/25] scsi: ufs: mediatek: Remove vendor kernel quirks cruft Nicolas Frattaroli
2026-01-06 13:25 ` Peter Wang (王信友)
2026-01-08 9:28 ` Nicolas Frattaroli
2026-01-09 6:20 ` Peter Wang (王信友)
2026-01-08 12:16 ` Krzysztof Kozlowski
2025-12-18 12:55 ` [PATCH v4 13/25] scsi: ufs: mediatek: Use the common PHY framework Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 14/25] scsi: ufs: mediatek: Switch to newer PM ops helpers Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 15/25] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 16/25] scsi: ufs: mediatek: Rework _ufs_mtk_clk_scale error paths Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 17/25] scsi: ufs: mediatek: Add vendor prefix to clk-scale-up-vcore-min Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 18/25] scsi: ufs: mediatek: Clean up logging prints Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 19/25] scsi: ufs: mediatek: Rework ufs_mtk_wait_idle_state Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 20/25] scsi: ufs: mediatek: Don't acquire dvfsrc-vcore twice Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 21/25] scsi: ufs: mediatek: Rework hardware version reading Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 22/25] scsi: ufs: mediatek: Back up idle timer in per-instance struct Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 23/25] scsi: ufs: mediatek: Make scale_us in setup_clk_gating const Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 24/25] scsi: ufs: mediatek: Remove ret local from link_startup_notify Nicolas Frattaroli
2025-12-18 12:55 ` [PATCH v4 25/25] scsi: ufs: mediatek: Add MT8196 compatible, update copyright Nicolas Frattaroli
2025-12-23 12:04 ` [PATCH v4 00/25] MediaTek UFS Cleanup and MT8196 Enablement AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e365223-8e20-4519-b290-d8ecff548d84@kernel.org \
--to=krzk@kernel.org \
--cc=Chaotian.Jing@mediatek.com \
--cc=Chunfeng.Yun@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=broonie@kernel.org \
--cc=bvanassche@acm.org \
--cc=chu.stanley@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=peter.wang@mediatek.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox