From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Brian Norris <briannorris@chromium.org>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-phy@lists.infradead.org, imx@lists.linux.dev
Subject: [PATCH v1 13/23] phy: freescale: Discard pm_runtime_put() return value
Date: Mon, 22 Dec 2025 21:18:46 +0100 [thread overview]
Message-ID: <2012926.taCxCBeP46@rafael.j.wysocki> (raw)
In-Reply-To: <6245770.lOV4Wx5bFT@rafael.j.wysocki>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Printing error messages on pm_runtime_put() returning negative values
is not particularly useful.
Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.
Accordingly, update mixel_lvds_phy_reset() to simply discard the return
value of pm_runtime_put().
This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
This patch is part of a series, but it doesn't depend on anything else
in that series. The last patch in the series depends on it.
It can be applied by itself and if you decide to do so, please let me
know.
Otherwise, an ACK or equivalent will be appreciated, but also the lack
of specific criticism will be eventually regarded as consent.
---
drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c
+++ b/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c
@@ -286,11 +286,9 @@ static int mixel_lvds_phy_reset(struct d
regmap_write(priv->regmap, PHY_CTRL, CTRL_RESET_VAL);
- ret = pm_runtime_put(dev);
- if (ret < 0)
- dev_err(dev, "failed to put PM runtime: %d\n", ret);
+ pm_runtime_put(dev);
- return ret;
+ return 0;
}
static struct phy *mixel_lvds_phy_xlate(struct device *dev,
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next parent reply other threads:[~2025-12-22 20:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6245770.lOV4Wx5bFT@rafael.j.wysocki>
2025-12-22 20:18 ` Rafael J. Wysocki [this message]
2025-12-22 20:21 ` [PATCH v1 14/23] phy: rockchip-samsung-dcphy: Discard pm_runtime_put() return value Rafael J. Wysocki
2025-12-22 20:22 ` [PATCH v1 15/23] phy: core: Discard pm_runtime_put() return values Rafael J. Wysocki
2025-12-30 10:34 ` Geert Uytterhoeven
2025-12-30 10:54 ` Geert Uytterhoeven
2025-12-30 15:05 ` Geert Uytterhoeven
2025-12-30 16:18 ` Rafael J. Wysocki
2025-12-30 16:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2012926.taCxCBeP46@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=briannorris@chromium.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox