From: Vinod Koul <vkoul@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-phy@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
Junlin Yang <yangjunlin@yulong.com>
Subject: [PATCH] phy: Revert "phy: ti: j721e-wiz: add missing of_node_put"
Date: Thu, 8 Apr 2021 11:59:14 +0530 [thread overview]
Message-ID: <20210408062914.3813102-1-vkoul@kernel.org> (raw)
This reverts commit 00f2e6f668b0 ("phy: ti: j721e-wiz: add missing of_node_put")
as it erroneously adds the of_node_put() as incorrect place.
Reported-by: Junlin Yang <yangjunlin@yulong.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/phy/ti/phy-j721e-wiz.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index 2b354680a272..a03866338d6a 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -1114,7 +1114,6 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
dev_err(dev,
"%s: Reading \"reg\" from \"%s\" failed: %d\n",
__func__, subnode->name, ret);
- of_node_put(subnode);
return ret;
}
of_property_read_u32(subnode, "cdns,num-lanes", &num_lanes);
--
2.26.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next reply other threads:[~2021-04-08 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 6:29 Vinod Koul [this message]
2021-04-12 5:05 ` [PATCH] phy: Revert "phy: ti: j721e-wiz: add missing of_node_put" Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408062914.3813102-1-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=yangjunlin@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox