From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43BAFC4320A for ; Wed, 11 Aug 2021 17:40:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1D0E6101D for ; Wed, 11 Aug 2021 17:40:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F1D0E6101D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8c33eJ5Fg1JXJappQOUpSJ8LHOLe1wQrCnHEh7Cy6qM=; b=UcoBocNIRF6a0N WAc7HHATfPWSYD8ejBhTrrsbr9oAcu/2qNdRSgm5QcOJyqdz1lqa3WP1q6knxkj6VDCgRoyRKvM2n MNgGFonb0EZIJmme6bmf4i/N0X48lQBR4JYxubXIH4L5L3dXZzAnv6fbqZZTwR1fSa+CacO8nMAtQ uB0aS7AXqiQCB5AZ/XOM4TmQO8CTCm0Eon/iGtR5avM7l/s9pLZdI/X1MCjVHVACACFF/gVaCkHIf Kq1BDcjtXYhs29kjJ0ru5xqMJhbkNc4PE+MZNS87Kz4AyGwwNuGIAMVp4LXhn+kXVtlcaSmCFw+X+ lqF1Eem8JCFLLewgJv/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDsCy-007oGZ-DC; Wed, 11 Aug 2021 17:40:04 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDsCt-007oFM-3m for linux-phy@lists.infradead.org; Wed, 11 Aug 2021 17:40:02 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 17BHdqsY001365; Wed, 11 Aug 2021 12:39:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1628703592; bh=EeqwQHMJVVet/Wz81B1nnj8xO0XYMvcfTM+AUUBD22w=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Y336EmtNzCHVUy1vovyPDMJlPfn4UUvmg77xOneQ5Tv6khStEGOHh03HbHIDVfkcr hvyDzGLmIARtMjjPmBDRZRviDTlSCsML83G5gM/hGkeGHgj2Jw7s5u0i3IrFzw3eOv X/obi81BB4EAqwdt6VIczImPAJSpzp0g60ABwGrs= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 17BHdqHb018479 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Aug 2021 12:39:52 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 11 Aug 2021 12:39:52 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 11 Aug 2021 12:39:52 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 17BHdpJ2029437; Wed, 11 Aug 2021 12:39:51 -0500 Date: Wed, 11 Aug 2021 23:09:50 +0530 From: Pratyush Yadav To: Vinod Koul CC: Nikhil Devshatwar , Tomi Valkeinen , Laurent Pinchart , Paul Kocialkowski , Vignesh Raghavendra , Chunfeng Yun , Kishon Vijay Abraham I , Peter Chen , , Subject: Re: [PATCH v3 2/7] phy: cdns-dphy: Prepare for Rx support Message-ID: <20210811173948.cezk6zu366c3huhw@ti.com> References: <20210624184108.21312-1-p.yadav@ti.com> <20210624184108.21312-3-p.yadav@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_103959_311453_64D1075A X-CRM114-Status: GOOD ( 33.14 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 06/08/21 03:48PM, Vinod Koul wrote: > On 25-06-21, 00:11, Pratyush Yadav wrote: > > The Rx programming sequence differs from the Tx programming sequence. > > Currently only Tx mode is supported. Move all the Tx related parts into > > a set of Tx-specific hooks that are then called by the main PHY > > framework hooks. This way when Rx support is added all that is needed to > > be done is to plug in the Rx hooks. > > > > The clocks "psm" and "pll_ref" are not used by the Rx path so make them > > optional in the probe and then check if they exist in the power_on() > > hook. > > > > Signed-off-by: Pratyush Yadav > > --- > > > > (no changes since v1) > > > > drivers/phy/cadence/cdns-dphy.c | 140 ++++++++++++++++++++++++-------- > > 1 file changed, 104 insertions(+), 36 deletions(-) > > > > diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dphy.c > > index ba042e39cfaf..8656f2102a91 100644 > > --- a/drivers/phy/cadence/cdns-dphy.c > > +++ b/drivers/phy/cadence/cdns-dphy.c > > @@ -75,6 +75,11 @@ struct cdns_dphy; > > struct cdns_dphy_ops { > > int (*probe)(struct cdns_dphy *dphy); > > void (*remove)(struct cdns_dphy *dphy); > > + int (*power_on)(struct cdns_dphy *dphy); > > + int (*power_off)(struct cdns_dphy *dphy); > > + int (*validate)(struct cdns_dphy *dphy, enum phy_mode mode, int submode, > > + union phy_configure_opts *opts); > > + int (*configure)(struct cdns_dphy *dphy, union phy_configure_opts *opts); > > void (*set_psm_div)(struct cdns_dphy *dphy, u8 div); > > void (*set_clk_lane_cfg)(struct cdns_dphy *dphy, > > enum cdns_dphy_clk_lane_cfg cfg); > > @@ -86,12 +91,18 @@ struct cdns_dphy_ops { > > struct cdns_dphy { > > struct cdns_dphy_cfg cfg; > > void __iomem *regs; > > + struct device *dev; > > struct clk *psm_clk; > > struct clk *pll_ref_clk; > > const struct cdns_dphy_ops *ops; > > struct phy *phy; > > }; > > > > +struct cdns_dphy_driver_data { > > + const struct cdns_dphy_ops *tx; > > + const struct cdns_dphy_ops *rx; > > +}; > > + > > static int cdns_dsi_get_dphy_pll_cfg(struct cdns_dphy *dphy, > > struct cdns_dphy_cfg *cfg, > > struct phy_configure_opts_mipi_dphy *opts, > > @@ -199,20 +210,9 @@ static void cdns_dphy_ref_set_psm_div(struct cdns_dphy *dphy, u8 div) > > dphy->regs + DPHY_PSM_CFG); > > } > > > > -/* > > - * This is the reference implementation of DPHY hooks. Specific integration of > > - * this IP may have to re-implement some of them depending on how they decided > > - * to wire things in the SoC. > > - */ > > -static const struct cdns_dphy_ops ref_dphy_ops = { > > - .get_wakeup_time_ns = cdns_dphy_ref_get_wakeup_time_ns, > > - .set_pll_cfg = cdns_dphy_ref_set_pll_cfg, > > - .set_psm_div = cdns_dphy_ref_set_psm_div, > > -}; > > - > > -static int cdns_dphy_config_from_opts(struct phy *phy, > > - struct phy_configure_opts_mipi_dphy *opts, > > - struct cdns_dphy_cfg *cfg) > > +static int cdns_dphy_tx_config_from_opts(struct phy *phy, > > + struct phy_configure_opts_mipi_dphy *opts, > > + struct cdns_dphy_cfg *cfg) > > { > > struct cdns_dphy *dphy = phy_get_drvdata(phy); > > unsigned int dsi_hfp_ext = 0; > > @@ -232,24 +232,13 @@ static int cdns_dphy_config_from_opts(struct phy *phy, > > return 0; > > } > > > > -static int cdns_dphy_validate(struct phy *phy, enum phy_mode mode, int submode, > > - union phy_configure_opts *opts) > > +static int cdns_dphy_tx_configure(struct cdns_dphy *dphy, > > + union phy_configure_opts *opts) > > { > > struct cdns_dphy_cfg cfg = { 0 }; > > - > > - if (mode != PHY_MODE_MIPI_DPHY) > > - return -EINVAL; > > - > > - return cdns_dphy_config_from_opts(phy, &opts->mipi_dphy, &cfg); > > -} > > - > > -static int cdns_dphy_configure(struct phy *phy, union phy_configure_opts *opts) > > -{ > > - struct cdns_dphy *dphy = phy_get_drvdata(phy); > > - struct cdns_dphy_cfg cfg = { 0 }; > > int ret; > > > > - ret = cdns_dphy_config_from_opts(phy, &opts->mipi_dphy, &cfg); > > + ret = cdns_dphy_tx_config_from_opts(dphy->phy, &opts->mipi_dphy, &cfg); > > if (ret) > > return ret; > > > > @@ -279,9 +268,21 @@ static int cdns_dphy_configure(struct phy *phy, union phy_configure_opts *opts) > > return 0; > > } > > > > -static int cdns_dphy_power_on(struct phy *phy) > > +static int cdns_dphy_tx_validate(struct cdns_dphy *dphy, enum phy_mode mode, > > + int submode, union phy_configure_opts *opts) > > { > > - struct cdns_dphy *dphy = phy_get_drvdata(phy); > > + struct cdns_dphy_cfg cfg = { 0 }; > > + > > + if (submode != PHY_MIPI_DPHY_SUBMODE_TX) > > + return -EINVAL; > > + > > + return cdns_dphy_tx_config_from_opts(dphy->phy, &opts->mipi_dphy, &cfg); > > +} > > + > > +static int cdns_dphy_tx_power_on(struct cdns_dphy *dphy) > > +{ > > + if (!dphy->psm_clk || !dphy->pll_ref_clk) > > + return -EINVAL; > > > > clk_prepare_enable(dphy->psm_clk); > > clk_prepare_enable(dphy->pll_ref_clk); > > @@ -293,16 +294,77 @@ static int cdns_dphy_power_on(struct phy *phy) > > return 0; > > } > > > > -static int cdns_dphy_power_off(struct phy *phy) > > +static int cdns_dphy_tx_power_off(struct cdns_dphy *dphy) > > { > > - struct cdns_dphy *dphy = phy_get_drvdata(phy); > > - > > clk_disable_unprepare(dphy->pll_ref_clk); > > clk_disable_unprepare(dphy->psm_clk); > > > > return 0; > > } > > > > +static const struct cdns_dphy_ops tx_ref_dphy_ops = { > > + .power_on = cdns_dphy_tx_power_on, > > + .power_off = cdns_dphy_tx_power_off, > > + .validate = cdns_dphy_tx_validate, > > + .configure = cdns_dphy_tx_configure, > > + .get_wakeup_time_ns = cdns_dphy_ref_get_wakeup_time_ns, > > + .set_pll_cfg = cdns_dphy_ref_set_pll_cfg, > > + .set_psm_div = cdns_dphy_ref_set_psm_div, > > +}; > > + > > +/* > > + * This is the reference implementation of DPHY hooks. Specific integration of > > + * this IP may have to re-implement some of them depending on how they decided > > + * to wire things in the SoC. > > + */ > > +static const struct cdns_dphy_driver_data ref_dphy_ops = { > > + .tx = &tx_ref_dphy_ops, > > +}; > > + > > +static int cdns_dphy_validate(struct phy *phy, enum phy_mode mode, int submode, > > + union phy_configure_opts *opts) > > +{ > > + struct cdns_dphy *dphy = phy_get_drvdata(phy); > > + > > + if (mode != PHY_MODE_MIPI_DPHY) > > + return -EINVAL; > > + > > + if (dphy->ops->validate) > > + return dphy->ops->validate(dphy, mode, submode, opts); > > + > > + return 0; > > +} > > + > > +static int cdns_dphy_power_on(struct phy *phy) > > +{ > > + struct cdns_dphy *dphy = phy_get_drvdata(phy); > > + > > + if (dphy->ops->power_on) > > + return dphy->ops->power_on(dphy); > > + > > + return 0; > > +} > > + > > +static int cdns_dphy_power_off(struct phy *phy) > > +{ > > + struct cdns_dphy *dphy = phy_get_drvdata(phy); > > + > > + if (dphy->ops->power_off) > > + return dphy->ops->power_off(dphy); > > + > > + return 0; > > +} > > why do you need a dphy specific power_on/off only to call internal > ops..? If there is no additional logic lets drop this and continue the > phy ops for this I don't clearly understand what you are trying to say. The internal ops (dphy->ops) are DPHY-specific. So for example, you might have different power on/off sequences for Rx and Tx mode DPHYs. You would then implement different power_on() and power_off() hooks for those and store them in dphy->ops. How else would you handle this? > > -- > ~Vinod -- Regards, Pratyush Yadav Texas Instruments Inc. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy