Re: [PATCH resend v4 1/3] dt-bindings: phy: Add lan966x-serdes binding

Horatiu Vultur
2021-11-30T16:09:53Z

The 11/30/2021 15:02, Geert Uytterhoeven wrote:
>
> Hi Horatio,

Hi Geert,

>
> On Tue, Nov 16, 2021 at 11:16 AM Horatiu Vultur
> <horatiu.vultur@microchip.com> wrote:
> > Document the lan966x ethernet serdes phy driver bindings.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>
> Thanks for your patch, which is now commit fd66e57e46a3d1b7
> ("dt-bindings: phy: Add lan966x-serdes binding") in phy/next.
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/microchip,lan966x-serdes.yaml
>
> > +examples:
> > + - |
> > + serdes: serdes@e2004010 {
> > + compatible = "microchip,lan966x-serdes";
> > + reg = <0xe202c000 0x9c>, <0xe2004010 0x4>;
> > + #phy-cells = <2>;
> > + };
>
> So this overlaps with the switch registers, cfr.
> Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> in net-next/master?
>
> switch: switch@e0000000 {
> compatible = "microchip,lan966x-switch";
> reg = <0xe0000000 0x0100000>,
> <0xe2000000 0x0800000>;
> ...
> };

Well, they will overlap, but the switch will not use the registers used
by the the serdes. The 'lan966x_main_iomap' inside lan966x_main.c will
decide which parts of the resource will be used.

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

--
/Horatiu