From: "Marek Behún" <kabel@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: linux-phy@lists.infradead.org,
"Kishon Vijay Abraham I" <kishon@ti.com>,
pali@kernel.org, "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Marek Behún" <kabel@kernel.org>
Subject: [PATCH phy v3 5/5] Revert "PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware"
Date: Mon, 3 Jan 2022 15:32:20 +0100 [thread overview]
Message-ID: <20220103143220.13070-6-kabel@kernel.org> (raw)
In-Reply-To: <20220103143220.13070-1-kabel@kernel.org>
From: Pali Rohár <pali@kernel.org>
This reverts commit b0c6ae0f8948a2be6bf4e8b4bbab9ca1343289b6.
Armada 3720 phy driver (phy-mvebu-a3700-comphy.c) does not return
-EOPNOTSUPP from phy_power_on() callback anymore.
So remove dead code which handles -EOPNOTSUPP return value.
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/pci/controller/pci-aardvark.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
index c3b725afa11f..e3794abe78b0 100644
--- a/drivers/pci/controller/pci-aardvark.c
+++ b/drivers/pci/controller/pci-aardvark.c
@@ -1473,9 +1473,7 @@ static int advk_pcie_enable_phy(struct advk_pcie *pcie)
}
ret = phy_power_on(pcie->phy);
- if (ret == -EOPNOTSUPP) {
- dev_warn(&pcie->pdev->dev, "PHY unsupported by firmware\n");
- } else if (ret) {
+ if (ret) {
phy_exit(pcie->phy);
return ret;
}
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-01-03 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 14:32 [PATCH phy v3 0/5] Armada 3720 comphy native implementation Marek Behún
2022-01-03 14:32 ` [PATCH phy v3 1/5] phy: marvell: phy-mvebu-a3700-comphy: Remove port from driver configuration Marek Behún
2022-01-03 14:32 ` [PATCH phy v3 2/5] phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation Marek Behún
2022-02-02 15:52 ` Vinod Koul
2022-02-03 21:39 ` Marek Behún
2022-01-03 14:32 ` [PATCH phy v3 3/5] Revert "ata: ahci: mvebu: Make SATA PHY optional for Armada 3720" Marek Behún
2022-01-03 14:32 ` [PATCH phy v3 4/5] Revert "usb: host: xhci: mvebu: make USB 3.0 " Marek Behún
2022-01-03 14:32 ` Marek Behún [this message]
2022-01-17 14:58 ` [PATCH phy v3 0/5] Armada 3720 comphy native implementation Marek Behún
2022-01-27 5:27 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103143220.13070-6-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pali@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).