From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B84E8C433EF for ; Wed, 5 Jan 2022 18:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XSnbDNqURbm0Ll0ZnmiblPWt+6mpJmztKnK1yPR8l44=; b=YA6zW7hB8O7AGk kCxp6tr9CYwGxN6TKvKYlchiYKYMeo3/NAHgPUvJRjbSK3/dXgcQvPURHgdgscBH6A7po6AJYLTTz SxSapJcq08Ydc/USdScgGFhwublYnXv2QW4rp2opDD12XBwgdMdbkeCtGuL+OXJ3YytnuHVeSUpWy O2t63X9qNeLAuNUbqOELNAIaL+cdObF4ecuuuiS1ZcYAnlgrPWD7sGo69yGXttX2nEZoUYfaQadok sHJTvX/jDmbT8XsHccKf4Ha5R13VsqbWrM/icZlotPdPRvBqLDR3XfccEU+2UnotKMp65e04kyFn5 H/hU/WvHPsY+a6s2sI9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5BER-00FdLa-41; Wed, 05 Jan 2022 18:41:55 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5BEO-00FdKP-3k for linux-phy@lists.infradead.org; Wed, 05 Jan 2022 18:41:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641408112; x=1672944112; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9jWTwzcroPAB6SjOmCs6Db9zm5qd0qwmZSImoWib7kg=; b=M1ScfJrVaAjlKFrce96lmYhESZF+4fKg4V+ANU0HdrR6HiSKP/aV+qBf Bxqeu3F8ipSkj/OVMxdIHQFd2tMGvHOnbiJRtxq2/NiycSuSWvGqZ1Yrp V4Hh0ULq75cksef7BIWOMM7i6dN9GdTgaQvqkQP0m9s2Z/XsDjEL5eUFF 6K5f8NcyOk3gaRykJmJ5/sA63kW6VebQ/+OT81bhW61o6xokVM4/ljWvs 7nHHzb2mztusv/neKxTCG7A5rw5P3D7tVwPPODMLE8enz/7dd9GqDGT1F pcGhVuSQEUdiBaAg64NCxyJVDMyERVydS0tgaCcr+0LbUO+tE4TjjQWhl g==; X-IronPort-AV: E=McAfee;i="6200,9189,10217"; a="222507006" X-IronPort-AV: E=Sophos;i="5.88,264,1635231600"; d="scan'208";a="222507006" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2022 10:41:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,264,1635231600"; d="scan'208";a="668198888" Received: from lkp-server01.sh.intel.com (HELO e357b3ef1427) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 05 Jan 2022 10:41:49 -0800 Received: from kbuild by e357b3ef1427 with local (Exim 4.92) (envelope-from ) id 1n5BEK-000Gwl-QQ; Wed, 05 Jan 2022 18:41:48 +0000 Date: Thu, 6 Jan 2022 02:41:35 +0800 From: kernel test robot To: Miaoqian Lin Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linmq006@gmail.com, Kishon Vijay Abraham I , Vinod Koul , Tony Lindgren , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: mapphone-mdm6600: Fix PM disable depth imbalance in phy_mdm6600_probe Message-ID: <202201060211.yT7coTKI-lkp@intel.com> References: <20220105123947.17946-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220105123947.17946-1-linmq006@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220105_104152_204040_DAEEBB4A X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Miaoqian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.16-rc8 next-20220105] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Miaoqian-Lin/phy-mapphone-mdm6600-Fix-PM-disable-depth-imbalance-in-phy_mdm6600_probe/20220105-204113 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c9e6606c7fe92b50a02ce51dda82586ebdf99b48 config: hexagon-randconfig-r035-20220105 (https://download.01.org/0day-ci/archive/20220106/202201060211.yT7coTKI-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d5b6e30ed3acad794dd0aec400e617daffc6cc3d) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/62cad5a4dd9feab731b40f99e6e0bf7a2429f1ed git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Miaoqian-Lin/phy-mapphone-mdm6600-Fix-PM-disable-depth-imbalance-in-phy_mdm6600_probe/20220105-204113 git checkout 62cad5a4dd9feab731b40f99e6e0bf7a2429f1ed # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/phy/motorola/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/phy/motorola/phy-mapphone-mdm6600.c:633:1: warning: unused label 'disable_pm' [-Wunused-label] disable_pm: ^~~~~~~~~~~ 1 warning generated. vim +/disable_pm +633 drivers/phy/motorola/phy-mapphone-mdm6600.c 555 556 static int phy_mdm6600_probe(struct platform_device *pdev) 557 { 558 struct phy_mdm6600 *ddata; 559 int error; 560 561 ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL); 562 if (!ddata) 563 return -ENOMEM; 564 565 INIT_DELAYED_WORK(&ddata->bootup_work, 566 phy_mdm6600_deferred_power_on); 567 INIT_DELAYED_WORK(&ddata->status_work, phy_mdm6600_status); 568 INIT_DELAYED_WORK(&ddata->modem_wake_work, phy_mdm6600_modem_wake); 569 init_completion(&ddata->ack); 570 571 ddata->dev = &pdev->dev; 572 platform_set_drvdata(pdev, ddata); 573 574 /* Active state selected in phy_mdm6600_power_on() */ 575 error = pinctrl_pm_select_sleep_state(ddata->dev); 576 if (error) 577 dev_warn(ddata->dev, "%s: error with sleep_state: %i\n", 578 __func__, error); 579 580 error = phy_mdm6600_init_lines(ddata); 581 if (error) 582 return error; 583 584 phy_mdm6600_init_irq(ddata); 585 schedule_delayed_work(&ddata->bootup_work, 0); 586 587 /* 588 * See phy_mdm6600_device_power_on(). We should be able 589 * to remove this eventually when ohci-platform can deal 590 * with -EPROBE_DEFER. 591 */ 592 msleep(PHY_MDM6600_PHY_DELAY_MS + 500); 593 594 /* 595 * Enable PM runtime only after PHY has been powered up properly. 596 * It is currently only needed after USB suspends mdm6600 and n_gsm 597 * needs to access the device. We don't want to do this earlier as 598 * gpio mode0 pin doubles as mdm6600 wake-up gpio. 599 */ 600 pm_runtime_use_autosuspend(ddata->dev); 601 pm_runtime_set_autosuspend_delay(ddata->dev, 602 MDM6600_MODEM_IDLE_DELAY_MS); 603 pm_runtime_enable(ddata->dev); 604 error = pm_runtime_get_sync(ddata->dev); 605 if (error < 0) { 606 dev_warn(ddata->dev, "failed to wake modem: %i\n", error); 607 pm_runtime_put_noidle(ddata->dev); 608 goto cleanup; 609 } 610 611 ddata->generic_phy = devm_phy_create(ddata->dev, NULL, &gpio_usb_ops); 612 if (IS_ERR(ddata->generic_phy)) { 613 error = PTR_ERR(ddata->generic_phy); 614 goto idle; 615 } 616 617 phy_set_drvdata(ddata->generic_phy, ddata); 618 619 ddata->phy_provider = 620 devm_of_phy_provider_register(ddata->dev, 621 of_phy_simple_xlate); 622 if (IS_ERR(ddata->phy_provider)) 623 error = PTR_ERR(ddata->phy_provider); 624 625 idle: 626 pm_runtime_mark_last_busy(ddata->dev); 627 pm_runtime_put_autosuspend(ddata->dev); 628 629 cleanup: 630 if (error < 0) 631 phy_mdm6600_device_power_off(ddata); 632 > 633 disable_pm: 634 pm_runtime_disable(ddata->dev); 635 636 return error; 637 } 638 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy