From: "zyf@rock-chips.com" <zyf@rock-chips.com>
To: "\"Rob Herring" <robh@kernel.org>
Cc: HeikoStübner <heiko@sntech.de>, robh+dt <robh+dt@kernel.org>,
"Johan Jonker" <jbx6244@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
"michael.riesch" <michael.riesch@wolfvision.net>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-phy <linux-phy@lists.infradead.org>, kishon <kishon@ti.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>, 陈亮 <cl@rock-chips.com>,
"Kever.Yang" <kever.yang@rock-chips.com>,
"Lee Jones" <lee.jones@linaro.org>, 吴良峰 <wulf@rock-chips.com>,
"david.wu@rock-chips.com" <david.wu@rock-chips.com>
Subject: Re: [PATCH v8 2/4] dt-bindings: phy: rockchip: Add Naneng combo PHY bindings
Date: Fri, 25 Feb 2022 15:35:14 +0800 [thread overview]
Message-ID: <2022022515341412692315@rock-chips.com> (raw)
In-Reply-To: YheZ4XDX9kG8CocF@matsya
Hi Rob,
I can't reproduce this issue unless revert "[v8,1/4] dt-bindings: soc: grf: add naneng combo phy register compatible".
build log:
DTC Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml
CHECK Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml
build environment:
yamllint version: yamllint 1.26.3
kernel base:
commit 44948bd49d878dad6c9707e34f4a06df73c3a800 (tag: next-20220224, origin/master, origin/HEAD)
dtschema version:
pip3 install dtschema --upgrade
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: dtschema in /home2/zyf/.local/lib/python3.6/site-packages (2021.10)
Collecting dtschema
Using cached dtschema-2022.1-py3-none-any.whl (63 kB)
Requirement already satisfied: rfc3987 in /home2/zyf/.local/lib/python3.6/site-packages (from dtschema) (1.3.8)
Requirement already satisfied: ruamel.yaml>0.15.69 in /home2/zyf/.local/lib/python3.6/site-packages (from dtschema) (0.17.16)
Using cached dtschema-2021.12-py3-none-any.whl (62 kB)
Requirement already satisfied: jsonschema>=3.0.1 in /home2/zyf/.local/lib/python3.6/site-packages (from dtschema) (4.0.0)
Requirement already satisfied: importlib-metadata in /home2/zyf/.local/lib/python3.6/site-packages (from jsonschema>=3.0.1->dtschema) (4.8.3)
Requirement already satisfied: pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0 in /home2/zyf/.local/lib/python3.6/site-packages (from jsonschema>=3.0.1->dtschema) (0.18.0)
Requirement already satisfied: attrs>=17.4.0 in /home2/zyf/.local/lib/python3.6/site-packages (from jsonschema>=3.0.1->dtschema) (21.4.0)
Requirement already satisfied: ruamel.yaml.clib>=0.1.2 in /home2/zyf/.local/lib/python3.6/site-packages (from ruamel.yaml>0.15.69->dtschema) (0.2.6)
Requirement already satisfied: typing-extensions>=3.6.4 in /home2/zyf/.local/lib/python3.6/site-packages (from importlib-metadata->jsonschema>=3.0.1->dtschema) (4.1.1)
Requirement already satisfied: zipp>=0.5 in /home2/zyf/.local/lib/python3.6/site-packages (from importlib-metadata->jsonschema>=3.0.1->dtschema) (3.6.0)
>From:"Rob Herring <robh@kernel.org>"
>To:Yifeng Zhao <yifeng.zhao@rock-chips.com>
>Date:2022-02-09 04:33:32
>Subject:Re: [PATCH v8 2/4] dt-bindings: phy: rockchip: Add Naneng combo PHY bindings
>
>On Tue, 08 Feb 2022 17:13:24 +0800, Yifeng Zhao wrote:
>> Add the compatible strings for the Naneng combo PHY found on rockchip SoC.
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>>
>> Changes in v8: None
>> Changes in v7:
>> - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel
>>
>> Changes in v5:
>> - modify description for ssc and ext-refclk
>> - remove apb reset
>>
>> Changes in v4:
>> - restyle
>> - remove some minItems
>> - add more properties
>> - remove reset-names
>> - move #phy-cells
>> - add rockchip,rk3568-pipe-grf
>> - add rockchip,rk3568-pipe-phy-grf
>>
>> Changes in v3: None
>> Changes in v2:
>> - Fix dtschema/dtc warnings/errors
>>
>> .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++
>> 1 file changed, 109 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
>>
>
>My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
>yamllint warnings/errors:
>
>dtschema/dtc warnings/errors:
>Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc50000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-grf', 'syscon']
>Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc70000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-phy-grf', 'syscon']
>
>doc reference errors (make refcheckdocs):
>
>See https://patchwork.ozlabs.org/patch/1589719
>
>This check can fail if there are any dependencies. The base for a patch
>series is generally the most recent rc1.
>
>If you already ran 'make dt_binding_check' and didn't see the above
>error(s), then make sure 'yamllint' is installed and dt-schema is up to
>date:
>
>pip3 install dtschema --upgrade
>
>Please check and re-submit.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-02-25 7:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 9:13 [PATCH v8 0/4] Add Naneng combo PHY support for RK3568 Yifeng Zhao
2022-02-08 9:13 ` [PATCH v8 1/4] dt-bindings: soc: grf: add naneng combo phy register compatible Yifeng Zhao
2022-02-08 9:13 ` [PATCH v8 2/4] dt-bindings: phy: rockchip: Add Naneng combo PHY bindings Yifeng Zhao
2022-02-08 20:33 ` Rob Herring
2022-02-09 3:38 ` zyf
2022-02-09 9:14 ` Heiko Stübner
2022-02-28 19:17 ` Rob Herring
2022-02-28 21:36 ` Peter Geis
2022-03-01 14:06 ` Rob Herring
2022-03-02 8:16 ` Vinod Koul
2022-02-08 9:13 ` [PATCH v8 3/4] phy: rockchip: add naneng combo phy for RK3568 Yifeng Zhao
2022-02-08 17:40 ` Peter Geis
2022-02-08 9:13 ` [PATCH v8 4/4] arm64: dts: rockchip: add naneng combo phy nodes for rk3568 Yifeng Zhao
2022-02-09 20:16 ` Aw: " Frank Wunderlich
2022-02-09 16:39 ` Aw: [PATCH v8 0/4] Add Naneng combo PHY support for RK3568 Frank Wunderlich
2022-02-24 14:44 ` Vinod Koul
2022-02-25 7:35 ` zyf [this message]
2022-02-25 16:05 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2022022515341412692315@rock-chips.com \
--to=zyf@rock-chips.com \
--cc=cl@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=wulf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).