Re: [PATCH 1/3] phy: qcom-qmp-pcie: drop obsolete pipe clock type check

Johan Hovold
2022-06-23T11:51:57Z

On Thu, Jun 23, 2022 at 02:44:28PM +0300, Dmitry Baryshkov wrote:
> On Thu, 23 Jun 2022 at 14:33, Johan Hovold <johan+linaro@kernel.org> wrote:
> >
> > Drop the obsolete pipe clock handling which was used to treat the pipe
> > clock as optional for types other than PCIe and USB and which is no
> > longer needed since splitting the PHY driver.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---

> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > if (IS_ERR(qphy->pipe_clk)) {
> > - if (cfg->type == PHY_TYPE_PCIE ||
> > - cfg->type == PHY_TYPE_USB3) {
> > - ret = PTR_ERR(qphy->pipe_clk);
> > - if (ret != -EPROBE_DEFER)
> > - dev_err(dev,
> > - "failed to get lane%d pipe_clk, %d\n",
> > - id, ret);
> > - return ret;
> > - }
> > - qphy->pipe_clk = NULL;
> > + return dev_err_probe(dev, PTR_ERR(qphy->pipe_clk),
> > + "failed to get lane%d pipe clock\n", id);
> > }
>
> Please remove the brackets around a single statement.

For readability reasons I prefer keeping brackets around statements
spanning multiple lines instead of relying on indentation.

Johan