From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33B31C433EF for ; Fri, 15 Jul 2022 23:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=hqgFj8SHKvr8aevXOTgAl76s9Oy62yxiR06pcqwZJQ8=; b=ySzCGbOAZE6wGN jreRzYY9IusYMEQ5IIM5+B7J67Vqx/GuLEGE+HBbLRfRob9MRTdL9PdC1w+BY8TIgoR/MwbpOTfU5 plWR2yTKqyIfX/csw7DDGvcCdYhjw0w9C6CQOrT09X9fYJLq+HxMDDQnjJXSAe9Lv40ZS3p/Re3Q5 kxp9dAhQoYzWrDIkvoy5g3Od0qXK4pjsdGD2xofdTIypmKrjn9Rk3UHKj1go120iHdnfe3DLlq3Ge aEU4DywIEuWkQRBevbC4EqAfAIIq11uyBU5jvRl33e5d0zcIhei1o+8EDio0PXNUDTx53wPMKHxD0 VT++S1OiM5w24nQLJGyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCUbS-00B59p-FQ; Fri, 15 Jul 2022 23:20:10 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCU1c-00Aqmd-44 for linux-phy@lists.infradead.org; Fri, 15 Jul 2022 22:43:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5706EB82EE3; Fri, 15 Jul 2022 22:43:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE14BC34115; Fri, 15 Jul 2022 22:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657924986; bh=+Ghj1AGYNiL5sUfl4veMNlQQN216yF6xPHyedaWdvTs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=aQZObKXCg15oT9Y3LaBxVR/Jm2Ol1m3/FYzwFErSEvorEhDs0YiXE3aZPL7kuOh6z wbf/M2G71nWJhdA3te5TPI4vBEUwvl5NWRu7fi9i56xNuF+hvwvZ3ikoaL+cPIdVWx etLgA83V+OdaVazN2ibIv37FVQB19Kv4whwblBvA3Zzbvccco/ucmDYh4N8RL2GNnC JW+2UdrhHaF2kUKmiBMePz3Kag8V7EPdE0g2qqjgMI9GW51FmkBg22t0xAShQ/RxNg i4yfmqEwpDXGMru1kV8rcu9wkw8+GUV1Tp44oBvpRx2C2aRmIgDtk7x/QsQi9Rw40e qDyAyR+jiNB/w== Date: Fri, 15 Jul 2022 17:43:03 -0500 From: Bjorn Helgaas To: Vinod Koul Cc: Marek Szyprowski , linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, Jingoo Han , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Krzysztof Kozlowski , Alim Akhtar , Kishon Vijay Abraham I Subject: Re: [PATCH 1/2] phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks Message-ID: <20220715224303.GA1207726@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_154308_500098_CB7CA4AA X-CRM114-Status: GOOD ( 25.44 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Jul 15, 2022 at 05:05:30PM +0530, Vinod Koul wrote: > On 12-07-22, 15:12, Bjorn Helgaas wrote: > > On Tue, Jul 05, 2022 at 11:55:23AM +0530, Vinod Koul wrote: > > > On 29-06-22, 00:04, Marek Szyprowski wrote: > > > > The exynos-pcie driver called phy_power_on() and then phy_init() for some > > > > historical reasons. However the generic PHY framework assumes that the > > > > proper sequence is to call phy_init() first, then phy_power_on(). The > > > > operations done by both functions should be considered as one action and > > > > as such they are called by the exynos-pcie driver (without doing anything > > > > between them). The initialization is just a sequence of register writes, > > > > which cannot be altered, without breaking the hardware operation. > > > > > > > > To match the generic PHY framework requirement, simply move all register > > > > writes to the phy_init()/phy_exit() and drop power_on()/power_off() > > > > callbacks. This way the driver will also work with the old (incorrect) > > > > PHY initialization call sequence. > > > > > > Is the plan to merge thru pcie tree? > > > > I guess these patches should go together. I don't see any major > > exynos series pending, but I do have two minor pci-exynos.c patches in > > the queue. > > > > If you ack it (after resolution of your question below) I'd be happy > > to take both if it doesn't cause trouble for you. > > Done now. Is this an ack? I didn't see any response to your question (added back below). Are you happy with the patch as-is? > > > > @@ -51,6 +51,13 @@ static int exynos5433_pcie_phy_init(struct phy *phy) > > > > { > > > > struct exynos_pcie_phy *ep = phy_get_drvdata(phy); > > > > > > > > + regmap_update_bits(ep->pmureg, EXYNOS5433_PMU_PCIE_PHY_OFFSET, > > > > + BIT(0), 1); > > > > + regmap_update_bits(ep->fsysreg, PCIE_EXYNOS5433_PHY_GLOBAL_RESET, > > > > + PCIE_APP_REQ_EXIT_L1_MODE, 0); > > > > + regmap_update_bits(ep->fsysreg, PCIE_EXYNOS5433_PHY_L1SUB_CM_CON, > > > > + PCIE_REFCLK_GATING_EN, 0); > > > > + > > > > > > why not retain exynos5433_pcie_phy_power_on() and call it from here and > > > drop in ops. It would be clear to reader that these are for turning on > > > the phy... -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy