From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v4 29/30] phy: qcom-qmp-pcie-msm8996: drop reset lane suffix
Date: Tue, 30 Aug 2022 13:29:22 +0200 [thread overview]
Message-ID: <20220830112923.3725-30-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220830112923.3725-1-johan+linaro@kernel.org>
The lane reset is defined in the "lane" node so there's no need to keep
adding a redundant lane-number suffix to the reset name.
Update driver to support the new binding where the "lane" reset name has
been deprecated by instead requesting the reset by index.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
index 7b893c66cf75..a4ff15b289cd 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
@@ -860,7 +860,6 @@ int qcom_qmp_phy_pcie_msm8996_create(struct device *dev, struct device_node *np,
struct qcom_qmp *qmp = dev_get_drvdata(dev);
struct phy *generic_phy;
struct qmp_phy *qphy;
- char prop_name[MAX_PROP_NAME];
int ret;
qphy = devm_kzalloc(dev, sizeof(*qphy), GFP_KERNEL);
@@ -898,9 +897,7 @@ int qcom_qmp_phy_pcie_msm8996_create(struct device *dev, struct device_node *np,
"failed to get lane%d pipe clock\n", id);
}
- /* Get lane reset, if any */
- snprintf(prop_name, sizeof(prop_name), "lane%d", id);
- qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name);
+ qphy->lane_rst = of_reset_control_get_exclusive_by_index(np, 0);
if (IS_ERR(qphy->lane_rst)) {
dev_err(dev, "failed to get lane%d reset\n", id);
return PTR_ERR(qphy->lane_rst);
--
2.35.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-08-30 11:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 11:28 [PATCH v4 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix Johan Hovold
2022-08-30 11:28 ` [PATCH v4 01/30] dt-bindings: phy: qcom,qmp: fix bogus clock-cells property Johan Hovold
2022-08-30 11:28 ` [PATCH v4 02/30] dt-bindings: phy: qcom,qmp: sort compatible strings Johan Hovold
2022-08-30 11:28 ` [PATCH v4 03/30] dt-bindings: phy: qcom,qmp: drop redundant descriptions Johan Hovold
2022-08-30 11:28 ` [PATCH v4 04/30] dt-bindings: phy: qcom,qmp: fix child node description Johan Hovold
2022-08-30 11:28 ` [PATCH v4 05/30] dt-bindings: phy: qcom,qmp: clean up descriptions Johan Hovold
2022-08-30 11:28 ` [PATCH v4 06/30] dt-bindings: phy: qcom,qmp: clean up example Johan Hovold
2022-08-30 11:29 ` [PATCH v4 07/30] dt-bindings: phy: qcom,qmp: drop child-node comment Johan Hovold
2022-08-30 11:29 ` [PATCH v4 08/30] dt-bindings: phy: add qcom,msm8996-qmp-pcie-phy schema Johan Hovold
2022-08-30 11:29 ` [PATCH v4 09/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schema Johan Hovold
2022-08-30 11:29 ` [PATCH v4 10/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock names Johan Hovold
2022-08-30 11:29 ` [PATCH v4 11/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names Johan Hovold
2022-08-30 11:29 ` [PATCH v4 12/30] dt-bindings: phy: add QMP PCIe PHY schema Johan Hovold
2022-08-30 11:29 ` [PATCH v4 13/30] dt-bindings: phy: qcom,qmp-pcie: add missing child node schema Johan Hovold
2022-08-30 11:29 ` [PATCH v4 14/30] dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock name Johan Hovold
2022-08-30 11:29 ` [PATCH v4 15/30] dt-bindings: phy: add QMP UFS PHY schema Johan Hovold
2022-08-30 11:29 ` [PATCH v4 16/30] dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock Johan Hovold
2022-08-30 11:29 ` [PATCH v4 17/30] dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domain Johan Hovold
2022-08-30 11:29 ` [PATCH v4 18/30] dt-bindings: phy: qcom,qmp-ufs: add missing child node schema Johan Hovold
2022-08-30 11:29 ` [PATCH v4 19/30] dt-bindings: phy: add QMP USB PHY schema Johan Hovold
2022-08-30 11:29 ` [PATCH v4 20/30] dt-bindings: phy: qcom,qmp-usb: add missing child node schema Johan Hovold
2022-08-30 11:29 ` [PATCH v4 21/30] dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock name Johan Hovold
2022-08-30 11:29 ` [PATCH v4 22/30] dt-bindings: phy: qcom,qmp-usb: add missing qcom,sc7180-qmp-usb3-phy schema Johan Hovold
2022-08-30 11:29 ` [PATCH v4 23/30] dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells property Johan Hovold
2022-08-30 11:29 ` [PATCH v4 24/30] dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock name Johan Hovold
2022-08-30 11:29 ` [PATCH v4 25/30] phy: qcom-qmp-pcie: drop pipe clock lane suffix Johan Hovold
2022-08-30 11:29 ` [PATCH v4 26/30] phy: qcom-qmp-combo: drop unused lane reset Johan Hovold
2022-08-30 11:29 ` [PATCH v4 27/30] phy: qcom-qmp-combo: drop pipe clock lane suffix Johan Hovold
2022-08-30 11:29 ` [PATCH v4 28/30] phy: qcom-qmp-pcie-msm8996: " Johan Hovold
2022-08-30 11:29 ` Johan Hovold [this message]
2022-08-30 11:29 ` [PATCH v4 30/30] phy: qcom-qmp-usb: " Johan Hovold
2022-08-30 13:27 ` [PATCH v4 00/30] phy: qcom,qmp: fix dt-bindings and deprecate " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830112923.3725-30-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).