Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	linux-phy@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH v2] dt-bindings: phy: renesas,rcar-gen2-usb-phy: Convert to json-schema
Date: Thu, 15 Sep 2022 10:35:37 +0100	[thread overview]
Message-ID: <20220915093537.qqddtqx2lr5ttuck@krzk-bin> (raw)
In-Reply-To: <dbdcffd009302734fe2fb895ce04b72fa1ea4355.1663165000.git.geert+renesas@glider.be>

On Wed, 14 Sep 2022 16:17:37 +0200, Geert Uytterhoeven wrote:
> Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation
> to json-schema.
> 
> Add missing properties.
> Rename the device node from "usb-phy" to "usb-phy-controller", as it
> does not represent a USB PHY itself, and thus does not have a
> "#phy-cells" property.
> Rename the child nodes from "usb-channel" to "usb-phy", as these do
> represent USB PHYs.
> Drop the second example, as it doesn't add any value.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Rename nodes to fix "'#phy-cells' is a required property".
> 
> This is the final conversion to json-schema of DT bindings for Renesas
> ARM SoCs, hurray!
> 
> Note that there are still a few plain text bindings left for Renesas IP
> cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0).
> ---
>  .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ----------------
>  .../phy/renesas,rcar-gen2-usb-phy.yaml        | 123 ++++++++++++++++++
>  2 files changed, 123 insertions(+), 112 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt
>  create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/


usb-phy@e6590100: 'usb-channel@0' does not match any of the regexes: '^usb-phy@[02]$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/r8a77470-iwg23s-sbc.dtb

usb-phy@e6590100: 'usb-channel@0', 'usb-channel@2' do not match any of the regexes: '^usb-phy@[02]$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dtb
	arch/arm/boot/dts/r8a7742-iwg21d-q7.dtb
	arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dtb
	arch/arm/boot/dts/r8a7743-iwg20d-q7.dtb
	arch/arm/boot/dts/r8a7743-sk-rzg1m.dtb
	arch/arm/boot/dts/r8a7744-iwg20d-q7-dbcm-ca.dtb
	arch/arm/boot/dts/r8a7744-iwg20d-q7.dtb
	arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dtb
	arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dtb
	arch/arm/boot/dts/r8a7745-sk-rzg1e.dtb
	arch/arm/boot/dts/r8a7790-lager.dtb
	arch/arm/boot/dts/r8a7790-stout.dtb
	arch/arm/boot/dts/r8a7791-koelsch.dtb
	arch/arm/boot/dts/r8a7791-porter.dtb
	arch/arm/boot/dts/r8a7794-alt.dtb
	arch/arm/boot/dts/r8a7794-silk.dtb

usb-phy@e6590100: 'usb-phy@0' is a required property
	arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dtb
	arch/arm/boot/dts/r8a7742-iwg21d-q7.dtb
	arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dtb
	arch/arm/boot/dts/r8a7743-iwg20d-q7.dtb
	arch/arm/boot/dts/r8a7744-iwg20d-q7-dbcm-ca.dtb
	arch/arm/boot/dts/r8a7744-iwg20d-q7.dtb
	arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dtb
	arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dtb
	arch/arm/boot/dts/r8a77470-iwg23s-sbc.dtb
	arch/arm/boot/dts/r8a7790-lager.dtb
	arch/arm/boot/dts/r8a7790-stout.dtb
	arch/arm/boot/dts/r8a7791-koelsch.dtb
	arch/arm/boot/dts/r8a7791-porter.dtb
	arch/arm/boot/dts/r8a7794-alt.dtb
	arch/arm/boot/dts/r8a7794-silk.dtb

usb-phy@e6590100: 'usb-phy@2' is a required property
	arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dtb
	arch/arm/boot/dts/r8a7742-iwg21d-q7.dtb
	arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dtb
	arch/arm/boot/dts/r8a7743-iwg20d-q7.dtb
	arch/arm/boot/dts/r8a7744-iwg20d-q7-dbcm-ca.dtb
	arch/arm/boot/dts/r8a7744-iwg20d-q7.dtb
	arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dtb
	arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dtb
	arch/arm/boot/dts/r8a7790-lager.dtb
	arch/arm/boot/dts/r8a7790-stout.dtb
	arch/arm/boot/dts/r8a7791-koelsch.dtb
	arch/arm/boot/dts/r8a7791-porter.dtb
	arch/arm/boot/dts/r8a7794-alt.dtb
	arch/arm/boot/dts/r8a7794-silk.dtb

usb-phy@e6598100: 'usb-channel@0' does not match any of the regexes: '^usb-phy@[02]$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/r8a77470-iwg23s-sbc.dtb

usb-phy@e6598100: 'usb-phy@0' is a required property
	arch/arm/boot/dts/r8a77470-iwg23s-sbc.dtb

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2022-09-15  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 14:17 [PATCH v2] dt-bindings: phy: renesas,rcar-gen2-usb-phy: Convert to json-schema Geert Uytterhoeven
2022-09-15  9:35 ` Krzysztof Kozlowski [this message]
2022-09-15 11:12   ` Geert Uytterhoeven
2022-09-15 14:31     ` Krzysztof Kozlowski
2022-09-16 18:58     ` Rob Herring
2022-09-20  6:21 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220915093537.qqddtqx2lr5ttuck@krzk-bin \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox