linux-phy.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v3 05/11] phy: qcom-qmp-pcie: move power-down update
Date: Mon, 17 Oct 2022 08:50:07 +0200	[thread overview]
Message-ID: <20221017065013.19647-6-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221017065013.19647-1-johan+linaro@kernel.org>

Move the power-down-control register update that powers on the PHY to
the power-on handler so that it matches the power-off handler.

Note that the power-on handler is currently always called directly
after init.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index 1105d439828c..b42c5e185228 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -1976,7 +1976,6 @@ static int qmp_pcie_init(struct phy *phy)
 	struct qmp_phy *qphy = phy_get_drvdata(phy);
 	struct qcom_qmp *qmp = qphy->qmp;
 	const struct qmp_phy_cfg *cfg = qphy->cfg;
-	void __iomem *pcs = qphy->pcs;
 	int ret;
 
 	/* turn on regulator supplies */
@@ -2002,9 +2001,6 @@ static int qmp_pcie_init(struct phy *phy)
 	if (ret)
 		goto err_assert_reset;
 
-	qphy_setbits(pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL],
-			cfg->pwrdn_ctrl);
-
 	return 0;
 
 err_assert_reset:
@@ -2041,6 +2037,9 @@ static int qmp_pcie_power_on(struct phy *phy)
 	unsigned int mask, val, ready;
 	int ret;
 
+	qphy_setbits(pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL],
+			cfg->pwrdn_ctrl);
+
 	if (qphy->mode == PHY_MODE_PCIE_RC)
 		mode_tables = cfg->tables_rc;
 	else
-- 
2.37.3


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2022-10-17  6:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  6:50 [PATCH v3 00/11] phy: qcom-qmp: more fixes and cleanups (set 1) Johan Hovold
2022-10-17  6:50 ` [PATCH v3 01/11] phy: qcom-qmp: fix obsolete lane comments Johan Hovold
2022-10-17  6:50 ` [PATCH v3 02/11] phy: qcom-qmp-combo: drop unused UFS reset Johan Hovold
2022-10-17  6:50 ` [PATCH v3 03/11] phy: qcom-qmp-pcie: drop unused common-block registers Johan Hovold
2022-10-17  6:50 ` [PATCH v3 04/11] phy: qcom-qmp-pcie: clean up power-down handling Johan Hovold
2022-10-17  6:50 ` Johan Hovold [this message]
2022-10-17  6:50 ` [PATCH v3 06/11] phy: qcom-qmp-pcie-msm8996: " Johan Hovold
2022-10-17  6:50 ` [PATCH v3 07/11] phy: qcom-qmp-combo: " Johan Hovold
2022-10-17  6:50 ` [PATCH v3 08/11] phy: qcom-qmp-ufs: " Johan Hovold
2022-10-17  6:50 ` [PATCH v3 09/11] phy: qcom-qmp-usb: " Johan Hovold
2022-10-17  6:50 ` [PATCH v3 10/11] phy: qcom-qmp-pcie: clean up clock lists Johan Hovold
2022-10-17  6:50 ` [PATCH v3 11/11] phy: qcom-qmp-pcie: drop bogus register update Johan Hovold
2022-10-17  8:15 ` [PATCH v3 00/11] phy: qcom-qmp: more fixes and cleanups (set 1) Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017065013.19647-6-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).