From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Serge Semin <fancer.lancer@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-ide@vger.kernel.org, linux-phy@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
kernel@collabora.com
Subject: [PATCHv1 2/5] dt-bindings: ata: ahci: add RK3588 AHCI controller
Date: Thu, 13 Apr 2023 20:23:42 +0200 [thread overview]
Message-ID: <20230413182345.92557-3-sebastian.reichel@collabora.com> (raw)
In-Reply-To: <20230413182345.92557-1-sebastian.reichel@collabora.com>
Just like RK3568, the RK3588 has a DWC based AHCI controller.
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
FWIW IDK what exactly the ASIC clock is. The TRM does not provide any
details unfortunately. It is required for functional SATA, though.
---
.../devicetree/bindings/ata/snps,dwc-ahci-common.yaml | 6 ++++--
Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/ata/snps,dwc-ahci-common.yaml b/Documentation/devicetree/bindings/ata/snps,dwc-ahci-common.yaml
index c1457910520b..0df8f49431eb 100644
--- a/Documentation/devicetree/bindings/ata/snps,dwc-ahci-common.yaml
+++ b/Documentation/devicetree/bindings/ata/snps,dwc-ahci-common.yaml
@@ -31,11 +31,11 @@ properties:
PM-alive clock, RxOOB detection clock, embedded PHYs reference (Rx/Tx)
clock, etc.
minItems: 1
- maxItems: 4
+ maxItems: 5
clock-names:
minItems: 1
- maxItems: 4
+ maxItems: 5
items:
oneOf:
- description: Application APB/AHB/AXI BIU clock
@@ -50,6 +50,8 @@ properties:
const: rxoob
- description: SATA Ports reference clock
const: ref
+ - description: Rockchip ASIC clock
+ const: asic
resets:
description:
diff --git a/Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml b/Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml
index 5afa4b57ce20..c6a0d6c8b62c 100644
--- a/Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml
+++ b/Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml
@@ -23,9 +23,11 @@ properties:
const: snps,dwc-ahci
- description: SPEAr1340 AHCI SATA device
const: snps,spear-ahci
- - description: Rockhip RK3568 AHCI controller
+ - description: Rockhip AHCI controller
items:
- - const: rockchip,rk3568-dwc-ahci
+ - enum:
+ - rockchip,rk3568-dwc-ahci
+ - rockchip,rk3588-dwc-ahci
- const: snps,dwc-ahci
patternProperties:
--
2.39.2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-04-13 18:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 18:23 [PATCHv1 0/5] Add RK3588 SATA support Sebastian Reichel
2023-04-13 18:23 ` [PATCHv1 1/5] dt-bindings: soc: rockchip: add rk3588 pipe-phy syscon Sebastian Reichel
2023-04-18 20:38 ` Rob Herring
2023-04-13 18:23 ` Sebastian Reichel [this message]
2023-04-14 1:51 ` [PATCHv1 2/5] dt-bindings: ata: ahci: add RK3588 AHCI controller Damien Le Moal
2023-04-21 19:28 ` Serge Semin
2023-04-13 18:23 ` [PATCHv1 3/5] dt-bindings: phy: rockchip: rk3588 has two reset lines Sebastian Reichel
2023-04-18 20:41 ` Rob Herring
2023-04-18 21:44 ` Sebastian Reichel
2023-04-13 18:23 ` [PATCHv1 4/5] arm64: dts: rockchip: rk3588: add combo PHYs Sebastian Reichel
2023-04-13 18:23 ` [PATCHv1 5/5] arm64: dts: rockchip: rk3588: add SATA support Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413182345.92557-3-sebastian.reichel@collabora.com \
--to=sebastian.reichel@collabora.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox