From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Johan Hovold <johan@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <vkoul@kernel.org>,
<kishon@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<quic_wcheng@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-clk@vger.kernel.org>
Subject: Re: [PATCH v8 2/8] dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY
Date: Fri, 21 Apr 2023 15:28:39 +0530 [thread overview]
Message-ID: <20230421095838.GA5813@varda-linux.qualcomm.com> (raw)
In-Reply-To: <ZDz9t9TkBqZ1fcfn@hovoldconsulting.com>
On Mon, Apr 17, 2023 at 10:05:11AM +0200, Johan Hovold wrote:
> On Thu, Apr 06, 2023 at 09:41:49AM +0200, Krzysztof Kozlowski wrote:
> > On 05/04/2023 13:41, Varadarajan Narayanan wrote:
> > > Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574
> > >
> > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > > ---
> > > Changes in v8:
> > > - Update clock names for ipq9574
> > >
> > > Changes in v6:
> > > - Made power-domains optional
> > >
> > > Note: In the earlier patch sets, had used the (legacy)
> > > specification available in qcom,msm8996-qmp-usb3-phy.yaml. Moved
> > > to newer specification in qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> > > ---
> > > .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 43 +++++++++++++++++++---
> > > 1 file changed, 37 insertions(+), 6 deletions(-)
>
> > > + clock-names:
> > > + items:
> > > + - const: aux
> > > + - const: ref
> > > + - const: com_aux
> >
> > Can anyone explain me why do we name these (here and other Qualcomm
> > bindings) based on clock name, not input? Just because different clock
> > is fed to the block, does not necessarily mean the input should be named
> > differently.
>
> I guess part of the answer is that this has just been copied from the
> vendor dts and (almost) no one but Qualcomm has access to the
> documentation. What would the input names be here?
>
> Also note that there are SoCs that enable both 'cfg_ahb' and 'com_aux'
> (e.g. sc7180).
The clock name definitions are auto-generated based on the clock
tree definitions provided by the h/w team. We followed the naming
pattern done in the previous SoCs.
Thanks
Varada
>
> > > + - const: pipe
> > > +
> > > examples:
> > > - |
> > > #include <dt-bindings/clock/qcom,gcc-sc8280xp.h>
>
> Johan
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-04-21 9:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 11:41 [PATCH v8 0/8] Enable IPQ9754 USB Varadarajan Narayanan
2023-04-05 11:41 ` [PATCH v8 1/8] dt-bindings: phy: qcom,qusb2: Document IPQ9574 compatible Varadarajan Narayanan
2023-04-05 11:41 ` [PATCH v8 2/8] dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY Varadarajan Narayanan
2023-04-06 7:41 ` Krzysztof Kozlowski
2023-04-17 8:05 ` Johan Hovold
2023-04-21 9:58 ` Varadarajan Narayanan [this message]
2023-04-21 16:27 ` Krzysztof Kozlowski
2023-04-06 7:42 ` Krzysztof Kozlowski
2023-04-21 10:13 ` Varadarajan Narayanan
2023-04-21 14:19 ` Dmitry Baryshkov
2023-04-24 5:24 ` Varadarajan Narayanan
2023-04-05 11:41 ` [PATCH v8 3/8] dt-bindings: usb: dwc3: Add IPQ9574 compatible Varadarajan Narayanan
2023-04-06 7:43 ` Krzysztof Kozlowski
2023-04-21 10:16 ` Varadarajan Narayanan
2023-04-05 11:41 ` [PATCH v8 4/8] clk: qcom: gcc-ipq9574: Add USB related clocks Varadarajan Narayanan
2023-04-05 11:41 ` [PATCH v8 5/8] phy: qcom-qusb2: add QUSB2 support for IPQ9574 Varadarajan Narayanan
2023-04-21 21:08 ` Dmitry Baryshkov
2023-04-05 11:41 ` [PATCH v8 6/8] phy: qcom: qmp: Update IPQ9574 USB Phy initialization Sequence Varadarajan Narayanan
2023-04-05 11:41 ` [PATCH v8 7/8] arm64: dts: qcom: ipq9574: Add USB related nodes Varadarajan Narayanan
2023-04-21 21:07 ` Dmitry Baryshkov
2023-04-24 9:04 ` Varadarajan Narayanan
2023-04-24 11:17 ` Dmitry Baryshkov
2023-04-26 9:51 ` Varadarajan Narayanan
2023-04-27 17:50 ` Dmitry Baryshkov
2023-04-28 11:45 ` Varadarajan Narayanan
2023-04-05 11:41 ` [PATCH v8 8/8] arm64: dts: qcom: ipq9574: Enable USB Varadarajan Narayanan
2023-04-05 13:51 ` [PATCH v8 0/8] Enable IPQ9754 USB Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421095838.GA5813@varda-linux.qualcomm.com \
--to=quic_varada@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).