Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support

Changhuang Liang
2023-05-04T08:44:22Z

On 2023/5/4 15:26, Krzysztof Kozlowski wrote:
> On 04/05/2023 09:20, Changhuang Liang wrote:
>>>>
>>>> Krzysztof,
>>>>
>>>> I am confused about what to do next. How to add this power-controller's
>>>> node in device tree?
>>>>
>>>
>>> You just move power-domain-cells up.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> Like this?
>>
>> aon_syscon: syscon@17010000 {
>> compatible = "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu";
>> reg = <0x0 0x17010000 0x0 0x1000>;
>> #power-domain-cells = <1>;
>> };
>>
>> If right? I will tell the syscon patch's owner delete the "simple-mfd" in aon_syscon node.
>
> Yes, but your compatibles are now wrong. Just compatible =
> "starfive,jh7110-aon-syscon", "syscon".
>

If compatible = "starfive,jh7110-aon-syscon", "syscon". My pmu drivers need use
"starfive,jh7110-aon-syscon" to match. And my pmu series will add this
aon_syscon in yaml and device tree, so the syscon patch's owner don't need
to add the aon_syscon in its yaml and device tree?

Best regards,
Changhuang