Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support

Changhuang Liang
2023-05-04T09:49:07Z

On 2023/5/4 17:36, Krzysztof Kozlowski wrote:
> On 04/05/2023 10:43, Changhuang Liang wrote:
>>
>>
>> On 2023/5/4 15:26, Krzysztof Kozlowski wrote:
>>> On 04/05/2023 09:20, Changhuang Liang wrote:
>>>>>>
>>>>>> Krzysztof,
>>>>>>
>>>>>> I am confused about what to do next. How to add this power-controller's
>>>>>> node in device tree?
>>>>>>
>>>>>
>>>>> You just move power-domain-cells up.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>
>>>> Like this?
>>>>
>>>> aon_syscon: syscon@17010000 {
>>>> compatible = "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu";
>>>> reg = <0x0 0x17010000 0x0 0x1000>;
>>>> #power-domain-cells = <1>;
>>>> };
>>>>
>>>> If right? I will tell the syscon patch's owner delete the "simple-mfd" in aon_syscon node.
>>>
>>> Yes, but your compatibles are now wrong. Just compatible =
>>> "starfive,jh7110-aon-syscon", "syscon".
>>>
>>
>> If compatible = "starfive,jh7110-aon-syscon", "syscon". My pmu drivers need use
>> "starfive,jh7110-aon-syscon" to match.
>
> And how it would even work with your proposal
> "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu"?
>
> Try...
>
>> And my pmu series will add this
>> aon_syscon in yaml and device tree, so the syscon patch's owner don't need
>> to add the aon_syscon in its yaml and device tree?
>
> I don't understand. But if you need to drop syscon, sure, drop it.
>

Yes, I think it can drop aon_syscon node in syscon patch series. And maybe my
compatible = "starfive,jh7110-aon-pmu", "syscon"; is better.

aon_syscon: syscon@17010000 {
compatible = "starfive,jh7110-aon-pmu", "syscon";
reg = <0x0 0x17010000 0x0 0x1000>;
#power-domain-cells = <1>;
};

Best regards,
Krzysztof